-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-56276: Add tests to test_compare #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @csabella What's the status of this PR? Have a nice day |
Hi @matrixise, It hasn't been reviewed yet. I don't have any other updates. |
From test_compare part of PR-15167.
Merge conflicts were from test_compare part of #15167. Waiting for retest results. On issue, Martin Panter said, after committing doc changes, "Someone needs to decide whether to use Andy’s tests as they are, or perhaps modify or drop some or all of them." Cheryl created this PR from the test part of the last .diff file and review is still needed. |
Tests that I presume once passed now fail due to improved constant constant folding and identity checking of results. The following now prints True & True in batch mode, whereas the tests below presume the opposite. (In interactive mode, where each line is compiled separately, they print false as matching constants requires that they be compiled together.) I think all the is not tests should be deleted. Only leave 'a is a' test and 'a is not b' where b is bound to a different constant.
|
Retriggering the latest test suit so everyone concerned has access to the failed logs. |
They passed because they remain correct for CPython and the toy subclass, but are not part of the definition of Python.
Co-authored-by: Oleg Iarygin <[email protected]>
Co-authored-by: Oleg Iarygin <[email protected]>
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-104694 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit 68ee8b3) Co-authored-by: Cheryl Sabella <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Oleg Iarygin <[email protected]>
gh-56276: Add tests to test_compare (GH-3199) (cherry picked from commit 68ee8b3) Co-authored-by: Cheryl Sabella <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Oleg Iarygin <[email protected]>
The part of the Maier-Panter bpo patch that hasn't been committed yet (doc changes were).
Contributed by: Andy Maier.
Contributed by: Martin Panter.