Skip to content

Optional strict checking of overloads #4333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #5119
JukkaL opened this issue Dec 6, 2017 · 2 comments
Closed
Tracked by #5119

Optional strict checking of overloads #4333

JukkaL opened this issue Dec 6, 2017 · 2 comments

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Dec 6, 2017

Currently the type checking of overloads is unsafe. We could potentially make them safe through a configuration option, at the cost of some flexibility.

#4332 is a similar idea for isinstance checks, and some of the discussion there is also relevant here.

@ilevkivskyi
Copy link
Member

Btw, now the overload treatment is much more strict than it used to be, so I am not sure such flag would be valuable now.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jan 29, 2020

This flag doesn't seem worth it any more. @Michael0x2a's work on overloads has fixed some of the biggest issues, in particular.

@JukkaL JukkaL closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants