Skip to content

Commit 32adbec

Browse files
Erlend Egeberg Aaslandencukou
Erlend Egeberg Aasland
andauthored
PEP 687: amendments after feedback (#2521)
Co-authored-by: Petr Viktorin <[email protected]>
1 parent 0666a97 commit 32adbec

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pep-0687.rst

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ Content-Type: text/x-rst
88
Requires: 489, 573, 630
99
Created: 04-Apr-2022
1010
Python-Version: 3.11
11-
Post-History: `04-Apr-2022 <https://discuss.python.org/t/14824>`__
12-
11+
Post-History: `04-Apr-2022 <https://discuss.python.org/t/14824>`__,
12+
`11-Apr-2022 <https://mail.python.org/archives/list/[email protected]/thread/B3HYQIE4Z5WBJCC3FUZJZHXLM32I4BZA/>`__
1313

1414
Abstract
1515
========
@@ -67,6 +67,9 @@ All stdlib extension modules will be *isolated*. That is:
6767
Conversion to heap types
6868
------------------------
6969

70+
Static types that do not need module state access, and have no other reason to
71+
be converted, should stay static.
72+
7073
Types whose methods need access to their module instance will be converted
7174
to heap types following :pep:`630`, with the following considerations:
7275

@@ -97,9 +100,6 @@ If another kind of issue is found, the module in question should be unchanged
97100
until a solution is found and added to the Devguide, and already
98101
converted modules are checked and fixed.
99102

100-
Static types that do not need module state access, and have no other reason to
101-
be converted, should stay static.
102-
103103

104104
Process
105105
-------
@@ -137,7 +137,7 @@ smaller modules.
137137
3. Add relevant global variables to the module state ``struct``, and modify code
138138
that accesses the global state to use the module state helpers instead. This
139139
step may be broken into several PR's.
140-
4. Where necessary, convert heap types to static types.
140+
4. Where necessary, convert static types to heap types.
141141
5. Convert the global module state struct to true module state.
142142
6. Implement multi-phase initialisation.
143143

0 commit comments

Comments
 (0)