From 38c81b648dfe32c1d27ff82e0624363da8ce8e0a Mon Sep 17 00:00:00 2001 From: AlexWaygood Date: Wed, 12 Apr 2023 13:05:06 +0100 Subject: [PATCH 1/2] Remove flake8-noqa from test-requirements.txt --- .github/workflows/ci.yml | 1 + test-requirements.txt | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 82b3887b..0a273e83 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,6 +57,7 @@ jobs: run: | pip install --upgrade pip pip install -r test-requirements.txt + pip install flake8-noqa # not included in test-requirements.txt as it depends on typing-extensions - name: Lint implementation run: flake8 diff --git a/test-requirements.txt b/test-requirements.txt index ad5c3e58..675b2c5d 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -1,3 +1,2 @@ flake8 flake8-bugbear -flake8-noqa From dadfb8b17fb517c58a4c32ab26affd2474d63af8 Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Wed, 12 Apr 2023 13:09:03 +0100 Subject: [PATCH 2/2] better comment --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0a273e83..e813cb72 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,9 @@ jobs: run: | pip install --upgrade pip pip install -r test-requirements.txt - pip install flake8-noqa # not included in test-requirements.txt as it depends on typing-extensions + # not included in test-requirements.txt as it depends on typing-extensions, + # so it's a pain to have it installed locally + pip install flake8-noqa - name: Lint implementation run: flake8