File tree 1 file changed +15
-0
lines changed
1 file changed +15
-0
lines changed Original file line number Diff line number Diff line change @@ -393,6 +393,21 @@ code and leave comments in the pull request or issue tracker.
393
393
However, please be aware that if you are recommending a pull request as
394
394
'merge-ready', you should always make sure the entire test suite passes.
395
395
396
+ Leaving a Pull Request Review on GitHub
397
+ ---------------------------------------
398
+
399
+ When you review a pull request, you should provide additional details and context
400
+ of your review process.
401
+
402
+ Instead of simply "approving" the pull request, leave comments. For example:
403
+
404
+ #. If you tested the PR, report the result and the system and version tested on,
405
+ such as 'Windows 10', 'Ubuntu 16.4', or 'Mac High Sierra'.
406
+
407
+ #. If you request changes, try to suggest how.
408
+
409
+ #. Comment on what is "good" about the pull request, not just the "bad". Doing
410
+ so will make it easier for the PR author to find the good in your comments.
396
411
397
412
Dismissing Review from Another Core Developer
398
413
---------------------------------------------
You can’t perform that action at this time.
0 commit comments