fix(//core/conversion/evaluators): A couple fixes for evaluators

- Fixes aten::append to correctly append values and not pointers
- Fixes prim::RaiseException and aten::warn to print out strings

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>

Author: narendasan

Diff for: core/conversion/evaluators/aten.cpp

@@ -207,7 +207,7 @@ auto aten_registrations TRTORCH_UNUSED = RegisterNodeEvaluators()
             auto list = args.at(n->input(0)).IValue()->to<c10::List<c10::IValue>>();
             auto el = args.at(n->input(1)).IValue();
 
-            list.push_back(std::move(el));
+            list.push_back(std::move(*el));
             return list;
         },
         EvalOptions().validSchemas({
@@ -430,16 +430,16 @@ auto aten_registrations TRTORCH_UNUSED = RegisterNodeEvaluators()
         [](const torch::jit::Node* n, kwargs& args) -> c10::optional<torch::jit::IValue> {
             auto el = args.at(n->input(0)).unwrapToDouble();
 
-            return std::floor(el);
+            return static_cast<int64_t>(std::floor(el));
         },
         EvalOptions().validSchemas({
             "aten::floor.float(float a) -> (int)",
         })
     }).evaluator({
         c10::Symbol::fromQualString("aten::warn"),
         [](const torch::jit::Node* n, kwargs& args) -> c10::optional<torch::jit::IValue> {
-            auto warning = args.at(n->input(0)).IValue()->toString();
-            LOG_WARNING(warning);
+            auto warning = args.at(n->input(0)).IValue();
+            LOG_WARNING("Warning from TorchScript: " << *warning);
             return {};
         },
         EvalOptions()

Diff for: core/conversion/evaluators/prim.cpp

@@ -242,8 +242,8 @@ auto prim_registrations = RegisterNodeEvaluators()
     }).evaluator({
         c10::Symbol::fromQualString("prim::RaiseException"),
         [](const torch::jit::Node* n, kwargs& args) -> c10::optional<torch::jit::IValue> {
-            auto exception = args.at(n->input(0)).IValue()->toString();
-            TRTORCH_THROW_ERROR(exception);
+            auto exception = args.at(n->input(0)).IValue();
+            TRTORCH_THROW_ERROR("Error from TorchScript: " << *exception);
             return {};
         }
     });