Skip to content

Support Loop Translation to TensorRT #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
narendasan opened this issue Jun 23, 2020 · 14 comments
Closed

Support Loop Translation to TensorRT #112

narendasan opened this issue Jun 23, 2020 · 14 comments
Assignees
Labels
component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler feature request New feature or request No Activity

Comments

@narendasan
Copy link
Collaborator

In order to fully support RNNs, we want to be able to make recurrent subgraphs to TRT. To do so we must expand the capability of the compiler to recognize these cases and generate a TensorRT Loop.

@narendasan narendasan added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters labels Jun 23, 2020
@abhi-iyer
Copy link
Contributor

Some more issues we can address with this issue:

  1. Can we expand loop translation when unrolling the loop (see Lowering pass)?

  2. Can we backtrace through the graph and freeze and frozen operators?

@narendasan
Copy link
Collaborator Author

To add on, we want to be able to handle types like int inside the loop block at runtime. This will require probably doing things like mapping functions that operate on identified recurrence objects to a custom namespace tensor instead of int instead of standard aten to engage a converter instead of a evaluator and at conversion time freezing external dependencies in the TRT graph.

@narendasan narendasan linked a pull request Aug 3, 2020 that will close this issue
6 tasks
@narendasan narendasan reopened this Sep 23, 2020
@evanbro
Copy link

evanbro commented Nov 20, 2020

I'm currently receiving this message when converting my model with TRTorch TRTorch currently can only compile loops that are evaluatable at conversion time. What is the current timeline to add loop translation support for dynamic loop bodies? It's the main functionality missing in order for TRTorch to support my model.

@narendasan narendasan reopened this Feb 5, 2021
@narendasan narendasan added the feature request New feature or request label Feb 5, 2021
@narendasan narendasan self-assigned this Feb 5, 2021
@pytorch pytorch deleted a comment from github-actions bot Feb 5, 2021
@pytorch pytorch deleted a comment from github-actions bot Feb 5, 2021
@pytorch pytorch deleted a comment from github-actions bot Feb 5, 2021
@pytorch pytorch deleted a comment from github-actions bot Feb 5, 2021
@github-actions
Copy link

github-actions bot commented May 7, 2021

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@narendasan
Copy link
Collaborator Author

@evanbro We are landing partial compilation in TRTorch, this might help you run your model. Right now there is still no great solution for doing translation of dynamic loops into TensorRT directly.

@evanbro
Copy link

evanbro commented May 20, 2021

@evanbro We are landing partial compilation in TRTorch, this might help you run your model. Right now there is still no great solution for doing translation of dynamic loops into TensorRT directly.

Can you share more about partial compilation? Is there a PR or issue I can refer to?

@narendasan
Copy link
Collaborator Author

You can enable it with the "torch_fallback" option. #406

@github-actions
Copy link

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@github-actions
Copy link

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@github-actions
Copy link

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@ncomly-nvidia
Copy link
Contributor

@inocsin can you please confirm if #617 resolves this issue?

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@ncomly-nvidia
Copy link
Contributor

@inocsin confirmed offline. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler feature request New feature or request No Activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants