Skip to content

✨[Feature] Support cases where LowerGraph() introduces input whose values are stored in Param #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bowang007 opened this issue Jul 19, 2022 · 2 comments · Fixed by #1298
Assignees
Labels
bug Something isn't working component: lowering Issues re: The lowering / preprocessing passes feature request New feature or request

Comments

@bowang007
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
#1024
There are some models that LowerGraph() might introduce new input to the entire graph after lowering, which may cause the missing value error. As what is happening here #922 (comment) and here: #922 (comment).

Describe the solution you'd like
For now, in most cases it fails at the shape analysis phase since Torch-TensorRT cannot find the value for the missing input. We could introduce a pass to modify the graph and substitute the input by some constant or we can just add some mechanism to use the values from Params directly.

In the future Torch-TensorRT could handle these cases.

@github-actions
Copy link

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@ncomly-nvidia ncomly-nvidia added the bug Something isn't working label Nov 7, 2022
@ncomly-nvidia
Copy link
Contributor

@bowang007 this seems like a bug as well. partitioning should never change the I/O of the graph. CC: @narendasan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: lowering Issues re: The lowering / preprocessing passes feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants