Skip to content

🐛 [Bug] aten::unbind converter produces incorrect output dimensions #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mfeliz-cruise opened this issue Sep 23, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working component: converters Issues re: Specific op converters

Comments

@mfeliz-cruise
Copy link
Contributor

Bug Description

torch.unbind removes the dimension it splits on. The existing converter for aten::unbind preserves the dimension in its output. You can see the difference in the shapes below from the aten::unbind unit tests.

jit: [3, 4, 4]
trt: [1, 3, 4, 4]
jit: [3, 4, 4]
trt: [1, 3, 4, 4]

jit: [5]
trt: [5, 1]

To Reproduce

Steps to reproduce the behavior:

  1. Remove the reshapes on the trt outputs from the aten::unbind unit test. You will see that the split dimension is preserved in the converter output and removed in the jit output.

Expected behavior

Environment

Build information about Torch-TensorRT can be found by turning on debug messages

  • Torch-TensorRT Version (e.g. 1.0.0):
  • PyTorch Version (e.g. 1.0):
  • CPU Architecture:
  • OS (e.g., Linux):
  • How you installed PyTorch (conda, pip, libtorch, source):
  • Build command you used (if compiling from source):
  • Are you using local sources or building from archives:
  • Python version:
  • CUDA version:
  • GPU models and configuration:
  • Any other relevant information:

Additional context

@github-actions
Copy link

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@peri044
Copy link
Collaborator

peri044 commented Mar 24, 2023

@mfeliz-cruise Can you let me know which test are you referring to ?
I ran this one https://github.com/pytorch/TensorRT/blob/main/tests/core/conversion/converters/test_select.cpp#L1176-L1201 and got

===== JIT RESULTS: [3, 4, 4]
===== TRT RESULTS: [3, 4, 4]

@mfeliz-cruise
Copy link
Contributor Author

My fix for this was merged in September: #1373

I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: converters Issues re: Specific op converters
Projects
None yet
Development

No branches or pull requests

4 participants