Skip to content

✨[Feature] Allow "pass-through" of engine-build errors in Dynamo #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gs-olive opened this issue May 17, 2023 · 0 comments · Fixed by #1952
Closed

✨[Feature] Allow "pass-through" of engine-build errors in Dynamo #1927

gs-olive opened this issue May 17, 2023 · 0 comments · Fixed by #1952
Assignees
@gs-olive
Labels
feature request New feature or request Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path

Comments

@gs-olive
Copy link
Collaborator

Currently, engine build errors in the torch_tensorrt.dynamo.torch_compile path are handled by returning graph.forward for that subgraph (effectively falling back to Torch). The interface should provide the option to users to instead halt the compilation entirely when a TRT Engine build fails. Additionally, if the user prefers to continue compilation in the event of an engine build failure, the error should be relayed via logging.error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gs-olive gs-olive

Labels
feature request New feature or request Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for passing through build issues in Dynamo compile gs-olive/TensorRT
1 participant
@gs-olive