Skip to content

[0.6 documentation] Custom kernels section could provide more steps #10031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kirklandsign opened this issue Apr 9, 2025 · 7 comments
Closed
Assignees
Labels
module: doc Issues related to documentation, both in docs/ and inlined in code triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@kirklandsign
Copy link
Contributor

kirklandsign commented Apr 9, 2025

📚 The doc issue

In https://pytorch.org/executorch/0.6/llm/getting-started.html#custom-kernels, can we provide more steps on how the yaml codegen and build works?

Suggest a potential alternative/fix

No response

cc @mergennachin @byjlw

@metascroy
Copy link
Contributor

@kirklandsign are you specifically looking for a description of how they look under the hood, or just how to use them?

cc @larryliu0820 @GregoryComer

@kirklandsign
Copy link
Contributor Author

Say I user wants to use these custom kernels, it's hard to follow that section if they are first time using it. I feel like https://pytorch.org/executorch/0.6/kernel-library-custom-aten-kernel.html#custom-kernel-libraries contains more info. Can we just direct to that page?

@metascroy
Copy link
Contributor

Say I user wants to use these custom kernels, it's hard to follow that section if they are first time using it. I feel like https://pytorch.org/executorch/0.6/kernel-library-custom-aten-kernel.html#custom-kernel-libraries contains more info. Can we just direct to that page?

I think that makes sense. Do you want to put up a PR and others can review it?

@larryliu0820
Copy link
Contributor

Say I user wants to use these custom kernels, it's hard to follow that section if they are first time using it. I feel like https://pytorch.org/executorch/0.6/kernel-library-custom-aten-kernel.html#custom-kernel-libraries contains more info. Can we just direct to that page?

Yes please. Thank you @kirklandsign !

@kirklandsign
Copy link
Contributor Author

BTW seems that https://pytorch.org/executorch/0.6/llm/getting-started.html#using-a-custom-operator-in-a-model is the only place in the website which mentioned replace_linear_with_custom_linear.

@kirklandsign
Copy link
Contributor Author

#10139

@GregoryComer GregoryComer added module: doc Issues related to documentation, both in docs/ and inlined in code triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 14, 2025
@metascroy
Copy link
Contributor

Looks like this is done now @kirklandsign ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: doc Issues related to documentation, both in docs/ and inlined in code triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

4 participants