-
Notifications
You must be signed in to change notification settings - Fork 537
"Building an ExecuTorch iOS Demo App" Feedback #10066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@shoumikhin is this something you could help clean up? |
@jathu can you elaborate please what's up with MPS? The demo app needs a model exported with MPS to run inference and tests. |
I was just suggesting we should remove the MPS export example to keep the instructions simple. Perhaps we can add another section at the bottom that expands on how to export an MPS backend?
We now include xnnpack and coreml exporting support in the macOS pip packages. So just be running
All the commands executed successfully, but what did fail was opening the Xcode project ( |
@jathu sorry, still not clear on MPS part. To provide more context, the demo app features the MPS support along with Core ML and XNNPACK. You can see it on a screenshot as one of the modes the app can run inference on the images. If we remove it, we drop that feature pretty much. Also the app has tests for MPS that we run as part of the CI. I guess I'm missing some recent updates on installation flow. You're saying users may not need to clone ET at all now, but just And given the PyPI doesn't come with a prebuilt MPS backend export tools (I guess?), that means we still gotta clone and install ET? |
@shoumikhin I see, I didn't realize the demo app requires the MPS export as well. Are you willing to consider stripping MPS out in favor of keeping the demo as simple as possible for new developers? So the demo app will only contain xnnpack + coreml. cc @mergennachin @byjlw
Yes, on macOS it will install coremltools as a dependency so you should be able to export models out of the box. See: #9483 (CoreML), and #9773 (xnnpack) |
Yeah, You can test by doing this today:
Can we have two versions of the app with CoreML+XNNPACK only (which means, people don't need to build clone at all. just use pip and SwiftPM) and MPS version (which requires people to clone and build from source). |
On other hand, how hard is it to add the necessary code from MPS backend to executorch PyPI? Iirc, they don't have much deps. |
@mergennachin I mean technically we can do that, e.g. add |
Leaving the demo app as is, ie. building ET from source, due to the lack of MPS support in PyPI package, since changing the app at this point would take more effort. |
📚 The doc issue
Suggest a potential alternative/fix
pip install executorch
and just focus on XNNPACK and CoreML. Remove references to MPS (for now)The text was updated successfully, but these errors were encountered: