Skip to content

python grad_check.py cuda Error google colab #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mr-yamraj opened this issue Sep 10, 2019 · 1 comment
Closed

python grad_check.py cuda Error google colab #42

mr-yamraj opened this issue Sep 10, 2019 · 1 comment

Comments

@mr-yamraj
Copy link

I am running it on google colab and python grad_check.py cuda is not passing successfully, others (py, cpp) are passing with no issues.

@ClementPinard
Copy link
Contributor

This is a known issue, related with the fact that fminf and fmaxf are casting to float32 and thus the grad_check will fail.

See end of issue #27 for a discussion about it.

Bottom line is you should not care about this test, as the float32 precision si enough most of the time. If you really need to have float64 precision, be it to pas the grad_check or anything else, you will need to change the code in The cuda/lltm_cuda_kernem.cu file. Be aware that it might trigger compilation errors with gcc7.

See a solution with arg casting in aforementioned issue in case it happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants