Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stream options and frame output structs to dedicated header(s) #618

Closed
dvrogozh opened this issue Apr 4, 2025 · 1 comment · Fixed by #620
Closed

Move stream options and frame output structs to dedicated header(s) #618

dvrogozh opened this issue Apr 4, 2025 · 1 comment · Fixed by #620

Comments

@dvrogozh
Copy link
Contributor

dvrogozh commented Apr 4, 2025

As discussed in:

A follow up after #606 - need to move the following structures to separate header(s) and break circular dependency between DeviceInterface.h and SingleStreamDecoder.h:

  • SingleStreamDecoder::VideoStreamOptions
  • SingleStreamDecoder::FrameOutput
  • SingleStreamDecoder::FrameBatchOutput
  • SingleStreamDecoder::AudioFramesOutput

CC: @scotts, @NicolasHug
This was referenced Apr 4, 2025
Merged
Open
Merged
@dvrogozh
Copy link
Contributor Author

dvrogozh commented Apr 4, 2025

See #620 for the proposed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move stream options and frame output structs to dedicated headers dvrogozh/torchcodec
1 participant
@dvrogozh