Skip to content

Create unit tests based on variable FPS video #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scotts opened this issue Apr 24, 2025 · 2 comments
Open

Create unit tests based on variable FPS video #653

scotts opened this issue Apr 24, 2025 · 2 comments
Labels
good first issue Good for newcomers

Comments

@scotts
Copy link
Contributor

scotts commented Apr 24, 2025

VideoDecoder can handle variable FPS videos in some scenarios, but doesn't handle them well in other scenarios. We should have some unit tests which use a variable FPS video. We should create a small variable FPS video and check it in. A command that can create one:

ffmpeg -i video.mp4 -vf "setpts=PTS*if((gt(N\,30))\,1\,2)+1/TB" -c:v libx264 -bf 0  var_fps_video.mp4

I think it's fine to use one of the kinds of videos FFmpeg can generate on-the-fly, such as testsrc or mandelbrot.

Everything in VideoDecoder should work in exact seeking mode. It will probably fail in approximate mode.

@scotts scotts added the good first issue Good for newcomers label Apr 24, 2025
@XueSongTap
Copy link

Can I work on this ?

@scotts
Copy link
Contributor Author

scotts commented Apr 24, 2025

@XueSongTap, absolutely! Some advice on the test video we create, let's see if we can keep it under 300 KB or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants