Skip to content

[BUG] - MarioRL Not Logging Last Episode #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alperenunlu opened this issue Nov 4, 2023 · 4 comments · Fixed by #2656
Closed

[BUG] - MarioRL Not Logging Last Episode #2651

alperenunlu opened this issue Nov 4, 2023 · 4 comments · Fixed by #2656
Assignees
@alperenunlu
Labels
bug docathon-h2-2023 rl Issues related to reinforcement learning tutorial, DQN, and so on

Comments

@alperenunlu
Copy link
Contributor

alperenunlu commented Nov 4, 2023 •
edited by pytorch-bot bot
Loading

Add Link

mario_rl_tutorial.py

Describe the bug

On MarioRL tutorial it's not logging the last episode.

Example:
episodes=40

It's logging

  • episode 0
  • episode 20

Then finishes without logging the last episode which is episode 39

Describe your environment

Platform: macOS
CUDA: no
PyTorch version: 2.1.0

cc @vmoens @nairbv @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen
@alperenunlu alperenunlu added the bug label Nov 4, 2023
@alperenunlu
Copy link
Contributor Author

@svekars

@alperenunlu alperenunlu changed the title [BUG] - MarioRL Logging Not Logging Last Episode [BUG] - MarioRL Not Logging Last Episode Nov 5, 2023
@svekars svekars added rl Issues related to reinforcement learning tutorial, DQN, and so on docathon-h2-2023 labels Nov 6, 2023
@vmoens
Copy link
Contributor

vmoens commented Nov 6, 2023

We could simply add one more episode in the loop and we’d get the # 40, Wdyt?

@alperenunlu
Copy link
Contributor Author

Yes we could, but still the last episode will run for nothing.

@alperenunlu alperenunlu mentioned this issue Nov 6, 2023
Merged
4 tasks
@alperenunlu
Copy link
Contributor Author

@vmoens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alperenunlu alperenunlu

Labels
bug docathon-h2-2023 rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logging to last episode
3 participants
@svekars @vmoens @alperenunlu