-
Notifications
You must be signed in to change notification settings - Fork 4.2k
docs: Fix incorrect usage description of ctx.save_for_backward #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix incorrect usage description of ctx.save_for_backward #3377
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3377
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @harshaljanjani! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
I’ve signed the Facebook CLA. I believe re-running the tests should reflect that. Thank you very much! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@jbschlosser or @albanD Does this look good? cc: @svekars |
beginner_source/examples_autograd/polynomial_custom_function.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
beginner_source/examples_autograd/polynomial_custom_function.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Svetlana Karslioglu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds ok, you can also link https://docs.pytorch.org/docs/stable/notes/extending.html#extending-torch-autograd for further details.
@albanD @svekars @sekyondaMeta |
Fixes #2797
Description
ctx.save_for_backward
in thetwo_layer_net_custom_function.py
tutorial. The original text incorrectly stated that arbitrary objects can be cached usingctx.save_for_backward
, whereas only tensors are supported.Checklist
cc @albanD @jbschlosser