[fbsync] Models doc revamp: final cleanup (#6049)

Summary:
* Remove models.rst

* Remove '- New'

* Put back torchhub section where it originally was

Reviewed By: NicolasHug

Differential Revision: D36760929

fbshipit-source-id: f31049101a6bdab43bef8a403c3fff5954226d8c

Author: YosuaMichael

docs/Makefile

@@ -6,9 +6,7 @@ ifneq ($(EXAMPLES_PATTERN),)
 endif
 
 # You can set these variables from the command line.
-# TODO: Once the models doc revamp is done, set back the -W option to raise
-# errors on warnings. See https://github.com/pytorch/vision/pull/5821#discussion_r850500693
-SPHINXOPTS    = -j auto $(EXAMPLES_PATTERN_OPTS)
+SPHINXOPTS    = -W -j auto $(EXAMPLES_PATTERN_OPTS)
 SPHINXBUILD   = sphinx-build
 SPHINXPROJ    = torchvision
 SOURCEDIR     = source

docs/source/conf.py

@@ -347,7 +347,6 @@ def inject_weight_metadata(app, what, name, obj, options, lines):
             metrics = meta.pop("_metrics")
             for dataset, dataset_metrics in metrics.items():
                 for metric_name, metric_value in dataset_metrics.items():
-                    metric_name = metric_name.replace("_", "-")
                     table.append((f"{metric_name} (on {dataset})", str(metric_value)))
 
             for k, v in meta.items():

docs/source/index.rst

@@ -38,7 +38,6 @@ architectures, and common image transformations for computer vision.
    ops
    io
    feature_extraction
-   models_new
 
 .. toctree::
    :maxdepth: 1