Add TODO and nullify install_post_deps_pytorch_xla

tengyifei · tengyifei · commit 8621943026b1 · 2025-04-03T22:55:02.000-07:00
diff --git a/.circleci/common.sh b/.circleci/common.sh
@@ -106,10 +106,10 @@ function install_pre_deps_pytorch_xla() {
 }
 
 
+# TODO(https://github.com/pytorch/xla/issues/8934): Remove PyTorch usage of this function, then
+# remove this function from the script.
 function install_post_deps_pytorch_xla() {
-  # Install dependencies after we built torch_xla. This is due to installing
-  # those packages can potentially trigger `pip install torch_xla` if torch_xla
-  # is not detected in the system.
+  true
 }
 
 function build_torch_xla() {

Original file line number	Diff line number	Diff line change
`@@ -106,10 +106,10 @@ function install_pre_deps_pytorch_xla() {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`
	`109`	`+# TODO(https://github.com/pytorch/xla/issues/8934): Remove PyTorch usage of this function, then`
	`110`	`+# remove this function from the script.`
`109`	`111`	`function install_post_deps_pytorch_xla() {`
`110`		`- # Install dependencies after we built torch_xla. This is due to installing`
`111`		- # those packages can potentially trigger `pip install torch_xla` if torch_xla
`112`		`- # is not detected in the system.`
	`112`	`+ true`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`function build_torch_xla() {`