Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upsample_bilinear2d_backward lowering on GPU #8754

Open
lukeliu15 opened this issue Feb 26, 2025 · 3 comments · May be fixed by #8916
Open

upsample_bilinear2d_backward lowering on GPU #8754

lukeliu15 opened this issue Feb 26, 2025 · 3 comments · May be fixed by #8916
Assignees
@ysiraichi
Labels
enhancement New feature or request lowering ATen Operation lowering

Comments

@lukeliu15
Copy link

🚀 Feature

upsample_bilinear2d_backward lowering on GPU

Motivation

We are running torch-xla with CUDA backend; while upsample_bilinear2d is lowered on GPU, upsample_bilinear2d_backward is not.
https://github.com/pytorch/xla/blob/master/torch_xla/csrc/aten_xla_type.cpp#L3615

Pitch

Support upsample_bilinear2d_backward lowering on GPU in addition to TPU.

It seems that GPU was previously added for upsample_bilinear2d: #3990, wondering if it's possible to do the same for upsample_bilinear2d_backward.

Alternatives

N/A

Additional context

N/A
@ysiraichi ysiraichi added enhancement New feature or request lowering ATen Operation lowering labels Feb 27, 2025
@ysiraichi
Copy link
Collaborator

Thank you for filing this issue.
Could you confirm that we are fallbacking by printing metrics.executed_fallback_ops()?

@lukeliu15
Copy link
Author

met.metrics_report():

Counter: aten::_local_scalar_dense
  Value: 12
Counter: aten::upsample_bilinear2d_backward
  Value: 90

metrics.executed_fallback_ops():

['aten::upsample_bilinear2d_backward', 'aten::_local_scalar_dense']

@ysiraichi
Copy link
Collaborator

Thank you for checking. I will take a look at it.

@ysiraichi ysiraichi self-assigned this Mar 5, 2025
This was referenced Mar 27, 2025
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysiraichi ysiraichi

Labels
enhancement New feature or request lowering ATen Operation lowering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lower upsample_bilinear2d_backward operation. pytorch/xla
2 participants
@ysiraichi @lukeliu15