Skip to content

Commit 85cefc3

Browse files
committed
Fixes issue #1070, Sphinx fails python 2.7
Fixes an issue where Sphinx fails with python < 3.5 because of an update to docutils to 0.18. Limited docutils for python 3.5. We also set some of the Sphinx limits from pywbem dev_requirements.txt.
1 parent 6b7c3f1 commit 85cefc3

File tree

4 files changed

+22
-3
lines changed

4 files changed

+22
-3
lines changed

dev-requirements.txt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,15 @@ PyYAML>=5.2,<5.3; python_version == '3.4'
6363
PyYAML>=5.3.1; python_version > '3.4'
6464

6565
# Sphinx (no imports, invoked via sphinx-build script):
66-
Sphinx>=1.7.6
66+
# Sphinx (no imports, invoked via sphinx-build script):
67+
# Keep in sync with rtd-requirements.txt
68+
# Sphinx 2.0.0 removed support for Python 2.7 and 3.4
69+
# Sphinx 4.0.0 breaks autodocsumm (issue #2697)
70+
# Sphinx 3.5.4 started including test for docutils version
71+
Sphinx>=1.7.6,<2.0.0; python_version <= '3.4'
72+
Sphinx>=3.5.4,!=4.0.0; python_version >= '3.5'
73+
# Issue #2787 docutils v=0.18/Sphinx incompatibility
74+
docutils<0.18; python_version <= '3.4'
6775
sphinx-git>=10.1.1
6876
GitPython>=2.1.1;
6977
sphinxcontrib-fulltoc>=1.2.0

docs/changes.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ Released: not yet
6363
* Fixed install error of wrapt 1.13.0 on Python 2.7 on Windows due to lack of
6464
MS Visual C++ 9.0 on GitHub Actions, by pinning it to <1.13.
6565

66+
* Fixed issue with Sphinx and python 2.7. (see issue #1070)
67+
6668
**Enhancements:**
6769

6870
* Added a 'pywbemlistener' command for running and managing WBEM listeners.

minimum-constraints.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ dparse>=0.5.1; python_version >= '3.5'
9797
tox==2.0.0
9898

9999
# Sphinx (no imports, invoked via sphinx-build script):
100-
Sphinx==1.7.6
100+
Sphinx==1.7.6; python_version <= '3.4'
101+
Sphinx== 3.5.4; python_version >= '3.5'
101102
sphinx-git==10.1.1
102103
GitPython==2.1.1
103104
sphinxcontrib-fulltoc==1.2.0

rtd-requirements.txt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ six>=1.14.0
55
ply>=3.10
66
PyYAML>=3.13
77
# M2Crypto>=0.30.1 # we cannot install M2Crypto because RTD does not have Swig
8-
Sphinx>=1.7.6
8+
# Sphinx (no imports, invoked via sphinx-build script):
9+
# Keep in sync with rtd-requirements.txt
10+
# Sphinx 2.0.0 removed support for Python 2.7 and 3.4
11+
# Sphinx 4.0.0 breaks autodocsumm (issue #2697)
12+
# Sphinx 3.5.4 started including test for docutils version
13+
Sphinx>=1.7.6,<2.0.0; python_version <= '3.4'
14+
Sphinx>=3.5.4,!=4.0.0; python_version >= '3.5'
15+
# Issue #2787 docutils v=0.18/Sphinx incompatibility
16+
docutils<0.18; python_version <= '3.4'
917
sphinx-git>=10.1.1
1018
sphinxcontrib-fulltoc>=1.2.0

0 commit comments

Comments
 (0)