Skip to content

Commit edb19a4

Browse files
qrortqrort
committed
Add database name to pg_database view: resolves ydb-platform#3068 
1 parent 9aaa2c1 commit edb19a4

24 files changed

+277
-83
lines changed

‎ydb/core/kqp/compute_actor/kqp_compute_actor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ IActor* CreateKqpComputeActor(const TActorId& executerId, ui64 txId, NYql::NDqPr
4848
const NYql::NDq::TComputeRuntimeSettings& settings, const NYql::NDq::TComputeMemoryLimits& memoryLimits,
4949
NWilson::TTraceId traceId,
5050
TIntrusivePtr<NActors::TProtoArenaHolder> arena,
51-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup);
51+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup, const TGUCSettings::TPtr& GUCSettings);
5252

5353
IActor* CreateKqpScanComputeActor(const TActorId& executerId, ui64 txId,
5454
NYql::NDqProto::TDqTask* task, NYql::NDq::IDqAsyncIoFactory::TPtr asyncIoFactory,

‎ydb/core/kqp/compute_actor/kqp_pure_compute_actor.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ TKqpComputeActor::TKqpComputeActor(const TActorId& executerId, ui64 txId, NDqPro
1515
const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
1616
const TComputeRuntimeSettings& settings, const TComputeMemoryLimits& memoryLimits,
1717
NWilson::TTraceId traceId, TIntrusivePtr<NActors::TProtoArenaHolder> arena,
18-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup)
19-
: TBase(executerId, txId, task, std::move(asyncIoFactory), functionRegistry, settings, memoryLimits, /* ownMemoryQuota = */ true, /* passExceptions = */ true, /*taskCounters = */ nullptr, std::move(traceId), std::move(arena))
18+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup, const TGUCSettings::TPtr& GUCSettings)
19+
: TBase(executerId, txId, task, std::move(asyncIoFactory), functionRegistry, settings, memoryLimits, /* ownMemoryQuota = */ true, /* passExceptions = */ true, /*taskCounters = */ nullptr, std::move(traceId), std::move(arena), GUCSettings)
2020
, ComputeCtx(settings.StatsMode)
2121
, FederatedQuerySetup(federatedQuerySetup)
2222
{
@@ -281,10 +281,11 @@ IActor* CreateKqpComputeActor(const TActorId& executerId, ui64 txId, NDqProto::T
281281
const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
282282
const TComputeRuntimeSettings& settings, const TComputeMemoryLimits& memoryLimits,
283283
NWilson::TTraceId traceId, TIntrusivePtr<NActors::TProtoArenaHolder> arena,
284-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup)
284+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup,
285+
const TGUCSettings::TPtr& GUCSettings)
285286
{
286287
return new TKqpComputeActor(executerId, txId, task, std::move(asyncIoFactory),
287-
functionRegistry, settings, memoryLimits, std::move(traceId), std::move(arena), federatedQuerySetup);
288+
functionRegistry, settings, memoryLimits, std::move(traceId), std::move(arena), federatedQuerySetup, GUCSettings);
288289
}
289290

290291
} // namespace NKqp

‎ydb/core/kqp/compute_actor/kqp_pure_compute_actor.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class TKqpComputeActor : public TDqSyncComputeActorBase<TKqpComputeActor> {
3030
const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
3131
const TComputeRuntimeSettings& settings, const TComputeMemoryLimits& memoryLimits,
3232
NWilson::TTraceId traceId, TIntrusivePtr<NActors::TProtoArenaHolder> arena,
33-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup);
33+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup, const TGUCSettings::TPtr& GUCSettings);
3434

3535
void DoBootstrap();
3636

@@ -70,7 +70,7 @@ IActor* CreateKqpComputeActor(const TActorId& executerId, ui64 txId, NDqProto::T
7070
const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
7171
const TComputeRuntimeSettings& settings, const TComputeMemoryLimits& memoryLimits,
7272
NWilson::TTraceId traceId, TIntrusivePtr<NActors::TProtoArenaHolder> arena,
73-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup);
73+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup, const TGUCSettings::TPtr& gucsettings);
7474

7575
} // namespace NKqp
7676
} // namespace NKikimr

‎ydb/core/kqp/executer_actor/kqp_data_executer.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,15 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da
129129
const NKikimrConfig::TTableServiceConfig::EChannelTransportVersion chanTransportVersion,
130130
const NKikimrConfig::TTableServiceConfig::TAggregationConfig& aggregation,
131131
const TActorId& creator, TDuration maximalSecretsSnapshotWaitTime, const TIntrusivePtr<TUserRequestContext>& userRequestContext,
132-
const bool enableOlapSink, const bool useEvWrite, ui32 statementResultIndex, const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup)
132+
const bool enableOlapSink, const bool useEvWrite, ui32 statementResultIndex, const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup,
133+
const TGUCSettings::TPtr& GUCSettings)
133134
: TBase(std::move(request), database, userToken, counters, executerRetriesConfig, chanTransportVersion, aggregation,
134135
maximalSecretsSnapshotWaitTime, userRequestContext, statementResultIndex, TWilsonKqp::DataExecuter, "DataExecuter", streamResult)
135136
, AsyncIoFactory(std::move(asyncIoFactory))
136137
, EnableOlapSink(enableOlapSink)
137138
, UseEvWrite(useEvWrite)
138139
, FederatedQuerySetup(federatedQuerySetup)
140+
, GUCSettings(GUCSettings)
139141
{
140142
Target = creator;
141143

@@ -2430,7 +2432,8 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da
24302432
.AllowSinglePartitionOpt = singlePartitionOptAllowed,
24312433
.UserRequestContext = GetUserRequestContext(),
24322434
.FederatedQuerySetup = FederatedQuerySetup,
2433-
.OutputChunkMaxSize = Request.OutputChunkMaxSize
2435+
.OutputChunkMaxSize = Request.OutputChunkMaxSize,
2436+
.GUCSettings = GUCSettings
24342437
});
24352438

24362439
auto err = Planner->PlanExecution();
@@ -2636,6 +2639,7 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da
26362639
bool EnableOlapSink = false;
26372640
bool UseEvWrite = false;
26382641
const std::optional<TKqpFederatedQuerySetup> FederatedQuerySetup;
2642+
const TGUCSettings::TPtr GUCSettings;
26392643

26402644
bool HasExternalSources = false;
26412645
bool SecretSnapshotRequired = false;
@@ -2680,11 +2684,11 @@ IActor* CreateKqpDataExecuter(IKqpGateway::TExecPhysicalRequest&& request, const
26802684
NYql::NDq::IDqAsyncIoFactory::TPtr asyncIoFactory, const NKikimrConfig::TTableServiceConfig::EChannelTransportVersion chanTransportVersion, const TActorId& creator,
26812685
TDuration maximalSecretsSnapshotWaitTime, const TIntrusivePtr<TUserRequestContext>& userRequestContext,
26822686
const bool enableOlapSink, const bool useEvWrite, ui32 statementResultIndex,
2683-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup)
2687+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup, const TGUCSettings::TPtr& GUCSettings)
26842688
{
26852689
return new TKqpDataExecuter(std::move(request), database, userToken, counters, streamResult, executerRetriesConfig,
26862690
std::move(asyncIoFactory), chanTransportVersion, aggregation, creator, maximalSecretsSnapshotWaitTime, userRequestContext,
2687-
enableOlapSink, useEvWrite, statementResultIndex, federatedQuerySetup);
2691+
enableOlapSink, useEvWrite, statementResultIndex, federatedQuerySetup, GUCSettings);
26882692
}
26892693

26902694
} // namespace NKqp

‎ydb/core/kqp/executer_actor/kqp_executer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ IActor* CreateKqpExecuter(IKqpGateway::TExecPhysicalRequest&& request, const TSt
104104
const NKikimrConfig::TTableServiceConfig::EChannelTransportVersion chanTransportVersion, const TActorId& creator,
105105
TDuration maximalSecretsSnapshotWaitTime, const TIntrusivePtr<TUserRequestContext>& userRequestContext,
106106
const bool enableOlapSink, const bool useEvWrite, ui32 statementResultIndex,
107-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup);
107+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup, const TGUCSettings::TPtr& GUCSettings);
108108

109109
IActor* CreateKqpSchemeExecuter(
110110
TKqpPhyTxHolder::TConstPtr phyTx, NKikimrKqp::EQueryType queryType, const TActorId& target,

‎ydb/core/kqp/executer_actor/kqp_executer_impl.cpp

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,17 @@ IActor* CreateKqpExecuter(IKqpGateway::TExecPhysicalRequest&& request, const TSt
8484
const NKikimrConfig::TTableServiceConfig::EChannelTransportVersion chanTransportVersion, const TActorId& creator,
8585
TDuration maximalSecretsSnapshotWaitTime, const TIntrusivePtr<TUserRequestContext>& userRequestContext,
8686
const bool enableOlapSink, const bool useEvWrite, ui32 statementResultIndex,
87-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup)
87+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup, const TGUCSettings::TPtr& GUCSettings)
8888
{
8989
if (request.Transactions.empty()) {
9090
// commit-only or rollback-only data transaction
9191
YQL_ENSURE(request.LocksOp == ELocksOp::Commit || request.LocksOp == ELocksOp::Rollback);
92-
return CreateKqpDataExecuter(std::move(request), database, userToken, counters, false, aggregation, executerRetriesConfig, std::move(asyncIoFactory), chanTransportVersion, creator, maximalSecretsSnapshotWaitTime, userRequestContext, enableOlapSink, useEvWrite, statementResultIndex, federatedQuerySetup);
92+
return CreateKqpDataExecuter(
93+
std::move(request), database, userToken, counters, false,
94+
aggregation, executerRetriesConfig, std::move(asyncIoFactory), chanTransportVersion, creator,
95+
maximalSecretsSnapshotWaitTime, userRequestContext, enableOlapSink, useEvWrite, statementResultIndex,
96+
federatedQuerySetup, /*GUCSettings*/nullptr
97+
);
9398
}
9499

95100
TMaybe<NKqpProto::TKqpPhyTx::EType> txsType;
@@ -107,13 +112,27 @@ IActor* CreateKqpExecuter(IKqpGateway::TExecPhysicalRequest&& request, const TSt
107112
switch (*txsType) {
108113
case NKqpProto::TKqpPhyTx::TYPE_COMPUTE:
109114
case NKqpProto::TKqpPhyTx::TYPE_DATA:
110-
return CreateKqpDataExecuter(std::move(request), database, userToken, counters, false, aggregation, executerRetriesConfig, std::move(asyncIoFactory), chanTransportVersion, creator, maximalSecretsSnapshotWaitTime, userRequestContext, enableOlapSink, useEvWrite, statementResultIndex, federatedQuerySetup);
115+
return CreateKqpDataExecuter(
116+
std::move(request), database, userToken, counters, false,
117+
aggregation, executerRetriesConfig, std::move(asyncIoFactory), chanTransportVersion, creator,
118+
maximalSecretsSnapshotWaitTime, userRequestContext, enableOlapSink, useEvWrite, statementResultIndex,
119+
federatedQuerySetup, /*GUCSettings*/nullptr
120+
);
111121

112122
case NKqpProto::TKqpPhyTx::TYPE_SCAN:
113-
return CreateKqpScanExecuter(std::move(request), database, userToken, counters, aggregation, executerRetriesConfig, preparedQuery, chanTransportVersion, maximalSecretsSnapshotWaitTime, userRequestContext, statementResultIndex);
123+
return CreateKqpScanExecuter(
124+
std::move(request), database, userToken, counters, aggregation,
125+
executerRetriesConfig, preparedQuery, chanTransportVersion, maximalSecretsSnapshotWaitTime, userRequestContext,
126+
statementResultIndex
127+
);
114128

115129
case NKqpProto::TKqpPhyTx::TYPE_GENERIC:
116-
return CreateKqpDataExecuter(std::move(request), database, userToken, counters, true, aggregation, executerRetriesConfig, std::move(asyncIoFactory), chanTransportVersion, creator, maximalSecretsSnapshotWaitTime, userRequestContext, enableOlapSink, useEvWrite, statementResultIndex, federatedQuerySetup);
130+
return CreateKqpDataExecuter(
131+
std::move(request), database, userToken, counters, true,
132+
aggregation, executerRetriesConfig, std::move(asyncIoFactory), chanTransportVersion, creator,
133+
maximalSecretsSnapshotWaitTime, userRequestContext, enableOlapSink, useEvWrite, statementResultIndex,
134+
federatedQuerySetup, GUCSettings
135+
);
117136

118137
default:
119138
YQL_ENSURE(false, "Unsupported physical tx type: " << (ui32)*txsType);

‎ydb/core/kqp/executer_actor/kqp_executer_impl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1983,7 +1983,7 @@ IActor* CreateKqpDataExecuter(IKqpGateway::TExecPhysicalRequest&& request, const
19831983
const NKikimrConfig::TTableServiceConfig::EChannelTransportVersion chanTransportVersion, const TActorId& creator,
19841984
TDuration maximalSecretsSnapshotWaitTime, const TIntrusivePtr<TUserRequestContext>& userRequestContext,
19851985
const bool enableOlapSink, const bool useEvWrite, ui32 statementResultIndex,
1986-
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup);
1986+
const std::optional<TKqpFederatedQuerySetup>& federatedQuerySetup, const TGUCSettings::TPtr& GUCSettings);
19871987

19881988
IActor* CreateKqpScanExecuter(IKqpGateway::TExecPhysicalRequest&& request, const TString& database,
19891989
const TIntrusiveConstPtr<NACLib::TUserToken>& userToken, TKqpRequestCounters::TPtr counters,

‎ydb/core/kqp/executer_actor/kqp_planner.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ TKqpPlanner::TKqpPlanner(TKqpPlanner::TArgs&& args)
7979
, UserRequestContext(args.UserRequestContext)
8080
, FederatedQuerySetup(args.FederatedQuerySetup)
8181
, OutputChunkMaxSize(args.OutputChunkMaxSize)
82+
, GUCSettings(std::move(args.GUCSettings))
8283
{
8384
if (!Database) {
8485
// a piece of magic for tests
@@ -203,6 +204,10 @@ std::unique_ptr<TEvKqpNode::TEvStartKqpTasksRequest> TKqpPlanner::SerializeReque
203204
request.SetOutputChunkMaxSize(OutputChunkMaxSize);
204205
}
205206

207+
if (GUCSettings) {
208+
request.SetSerializedGUCSettings(GUCSettings->SerializeToString());
209+
}
210+
206211
return result;
207212
}
208213

@@ -349,7 +354,7 @@ void TKqpPlanner::ExecuteDataComputeTask(ui64 taskId, bool shareMailbox, bool op
349354
limits.MemoryQuotaManager = std::make_shared<NYql::NDq::TGuaranteeQuotaManager>(limit * 2, limit);
350355

351356
auto computeActor = NKikimr::NKqp::CreateKqpComputeActor(ExecuterId, TxId, taskDesc, AsyncIoFactory,
352-
AppData()->FunctionRegistry, settings, limits, ExecuterSpan.GetTraceId(), TasksGraph.GetMeta().GetArenaIntrusivePtr(), FederatedQuerySetup);
357+
AppData()->FunctionRegistry, settings, limits, ExecuterSpan.GetTraceId(), TasksGraph.GetMeta().GetArenaIntrusivePtr(), FederatedQuerySetup, GUCSettings);
353358

354359
if (optimizeProtoForLocalExecution) {
355360
TVector<google::protobuf::Message*>& taskSourceSettings = static_cast<TKqpComputeActor*>(computeActor)->MutableTaskSourceSettings();

‎ydb/core/kqp/executer_actor/kqp_planner.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ class TKqpPlanner {
6262
const TIntrusivePtr<TUserRequestContext>& UserRequestContext;
6363
const std::optional<TKqpFederatedQuerySetup>& FederatedQuerySetup;
6464
const ui64 OutputChunkMaxSize = 0;
65+
const TGUCSettings::TPtr GUCSettings;
6566
};
6667

6768
TKqpPlanner(TKqpPlanner::TArgs&& args);
@@ -124,6 +125,7 @@ class TKqpPlanner {
124125
TIntrusivePtr<TUserRequestContext> UserRequestContext;
125126
const std::optional<TKqpFederatedQuerySetup> FederatedQuerySetup;
126127
const ui64 OutputChunkMaxSize;
128+
const TGUCSettings::TPtr GUCSettings;
127129

128130
public:
129131
static bool UseMockEmptyPlanner; // for tests: if true then use TKqpMockEmptyPlanner that leads to the error

‎ydb/core/kqp/executer_actor/kqp_scan_executer.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,8 @@ class TKqpScanExecuter : public TKqpExecuterBase<TKqpScanExecuter, EExecType::Sc
338338
.AllowSinglePartitionOpt = false,
339339
.UserRequestContext = GetUserRequestContext(),
340340
.FederatedQuerySetup = std::nullopt,
341-
.OutputChunkMaxSize = Request.OutputChunkMaxSize
341+
.OutputChunkMaxSize = Request.OutputChunkMaxSize,
342+
.GUCSettings = nullptr
342343
});
343344

344345
LOG_D("Execute scan tx, PendingComputeTasks: " << TasksGraph.GetTasks().size());

‎ydb/core/kqp/node_service/kqp_node_service.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,9 +498,13 @@ class TKqpNodeService : public TActorBootstrapped<TKqpNodeService> {
498498
taskCtx.ComputeActorId = Register(computeActor);
499499
info.MutableActorIds().emplace_back(taskCtx.ComputeActorId);
500500
} else {
501+
std::shared_ptr<TGUCSettings> GUCSettings;
502+
if (ev->Get()->Record.HasSerializedGUCSettings()) {
503+
GUCSettings = std::make_shared<TGUCSettings>(ev->Get()->Record.GetSerializedGUCSettings());
504+
}
501505
if (Y_LIKELY(!CaFactory)) {
502506
computeActor = CreateKqpComputeActor(request.Executer, txId, &dqTask, AsyncIoFactory,
503-
AppData()->FunctionRegistry, runtimeSettings, memoryLimits, NWilson::TTraceId(ev->TraceId), ev->Get()->Arena, FederatedQuerySetup);
507+
AppData()->FunctionRegistry, runtimeSettings, memoryLimits, NWilson::TTraceId(ev->TraceId), ev->Get()->Arena, FederatedQuerySetup, GUCSettings);
504508
taskCtx.ComputeActorId = Register(computeActor);
505509
} else {
506510
computeActor = CaFactory->CreateKqpComputeActor(request.Executer, txId, &dqTask,

‎ydb/core/kqp/session_actor/kqp_session_actor.cpp

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
174174
, QueryServiceConfig(queryServiceConfig)
175175
, MetadataProviderConfig(metadataProviderConfig)
176176
, KqpTempTablesAgentActor(kqpTempTablesAgentActor)
177+
, GUCSettings(std::make_shared<TGUCSettings>())
177178
{
178179
RequestCounters = MakeIntrusive<TKqpRequestCounters>();
179180
RequestCounters->Counters = Counters;
@@ -185,6 +186,7 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
185186
FillSettings.RowsLimitPerWrite = Config->_ResultRowsLimit.Get();
186187
FillSettings.Format = IDataProvider::EResultFormat::Custom;
187188
FillSettings.FormatDetails = TString(KikimrMkqlProtoFormat);
189+
FillGUCSettings();
188190

189191
auto optSessionId = TryDecodeYdbSessionId(SessionId);
190192
YQL_ENSURE(optSessionId, "Can't decode ydb session Id");
@@ -1165,6 +1167,12 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
11651167
return false;
11661168
}
11671169

1170+
void FillGUCSettings() {
1171+
if (Settings.Database) {
1172+
GUCSettings->Set("database", Settings.Database.substr(1, Settings.Database.Size() - 1));
1173+
}
1174+
}
1175+
11681176
void SendToSchemeExecuter(const TKqpPhyTxHolder::TConstPtr& tx) {
11691177
YQL_ENSURE(QueryState);
11701178

@@ -1202,7 +1210,7 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
12021210
RequestCounters, Settings.TableService.GetAggregationConfig(), Settings.TableService.GetExecuterRetriesConfig(),
12031211
AsyncIoFactory, QueryState ? QueryState->PreparedQuery : nullptr, Settings.TableService.GetChannelTransportVersion(), SelfId(), 2 * TDuration::Seconds(MetadataProviderConfig.GetRefreshPeriodSeconds()),
12041212
QueryState ? QueryState->UserRequestContext : MakeIntrusive<TUserRequestContext>("", Settings.Database, SessionId),
1205-
Settings.TableService.GetEnableOlapSink(), useEvWrite, QueryState ? QueryState->StatementResultIndex : 0, FederatedQuerySetup);
1213+
Settings.TableService.GetEnableOlapSink(), useEvWrite, QueryState ? QueryState->StatementResultIndex : 0, FederatedQuerySetup, GUCSettings);
12061214

12071215
auto exId = RegisterWithSameMailbox(executerActor);
12081216
LOG_D("Created new KQP executer: " << exId << " isRollback: " << isRollback);
@@ -2411,7 +2419,7 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
24112419
bool HasOlapTable = false;
24122420
bool HasOltpTable = false;
24132421

2414-
TGUCSettings::TPtr GUCSettings = std::make_shared<TGUCSettings>();
2422+
TGUCSettings::TPtr GUCSettings;
24152423
};
24162424

24172425
} // namespace
@@ -2427,8 +2435,7 @@ IActor* CreateKqpSessionActor(const TActorId& owner, const TString& sessionId,
24272435
{
24282436
return new TKqpSessionActor(owner, sessionId, kqpSettings, workerSettings, federatedQuerySetup,
24292437
std::move(asyncIoFactory), std::move(moduleResolverState), counters,
2430-
queryServiceConfig, metadataProviderConfig, kqpTempTablesAgentActor
2431-
);
2438+
queryServiceConfig, metadataProviderConfig, kqpTempTablesAgentActor);
24322439
}
24332440

24342441
}

0 commit comments

Comments
 (0)