QLoggingRegistry: don't use QTextStream for the QT_LOGGING_RULES env var

We can use the existing QStringView-based rules parser. Additionally, we
can make this even better by avoiding the QString::replace() call and
simply tokenize on the semi-colon character (';').

Change-Id: I89d3890da482fc684abafffdd56ec17cad908f21
Reviewed-by: Ivan Solovev <[email protected]>

Author: thiagomacieira

src/corelib/io/qloggingregistry.cpp

@@ -152,10 +152,10 @@ void QLoggingRule::parse(QStringView pattern)
     \internal
     Parses configuration from \a content.
 */
-void QLoggingSettingsParser::setContent(QStringView content)
+void QLoggingSettingsParser::setContent(QStringView content, char16_t separator)
 {
     _rules.clear();
-    for (auto line : qTokenize(content, u'\n'))
+    for (auto line : qTokenize(content, separator))
         parseNextLine(line);
 }
 
@@ -298,12 +298,11 @@ void QLoggingRegistry::initializeRules()
     if (qtLoggingDebug())
         debugMsg("Checking %s environment variable", "QT_LOGGING_RULES");
 
-    const QByteArray rulesSrc = qgetenv("QT_LOGGING_RULES").replace(';', '\n');
+    const QString rulesSrc = qEnvironmentVariable("QT_LOGGING_RULES");
     if (!rulesSrc.isEmpty()) {
-        QTextStream stream(rulesSrc);
         QLoggingSettingsParser parser;
         parser.setImplicitRulesSection(true);
-        parser.setContent(stream);
+        parser.setContent(rulesSrc, u';');
 
         if (qtLoggingDebug())
             debugMsg("Loaded %td rules", static_cast<ptrdiff_t>(parser.rules().size()));

src/corelib/io/qloggingregistry_p.h

@@ -81,7 +81,7 @@ class Q_AUTOTEST_EXPORT QLoggingSettingsParser
 public:
     void setImplicitRulesSection(bool inRulesSection) { m_inRulesSection = inRulesSection; }
 
-    void setContent(QStringView content);
+    void setContent(QStringView content, char16_t separator = u'\n');
     void setContent(QTextStream &stream);
 
     QList<QLoggingRule> rules() const { return _rules; }