Skip to content

Commit 30b6c39

Browse files
authored
Fix test_notebooks_against_cirq_head for MacOS platform (#6366)
* And enable that test in CI-daily on MacOS Partially implements #6336
1 parent 6ea5ae1 commit 30b6c39

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/ci-daily.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ jobs:
8686
pip install \
8787
-r dev_tools/requirements/deps/format.txt \
8888
-r dev_tools/requirements/deps/pylint.txt \
89-
-r dev_tools/requirements/deps/pytest.txt
89+
-r dev_tools/requirements/deps/pytest.txt \
90+
-r dev_tools/requirements/deps/notebook.txt
9091
- name: Pytest check
9192
run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --enable-slow-tests

dev_tools/notebooks/notebook_test.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121

2222
import importlib.metadata
2323
import os
24-
import sys
2524
import tempfile
2625

2726
import pytest
2827

2928
from dev_tools import shell_tools
3029
from dev_tools.notebooks import filter_notebooks, list_all_notebooks, rewrite_notebook
30+
from dev_tools.test_utils import only_on_posix
3131

3232
SKIP_NOTEBOOKS = [
3333
# skipping vendor notebooks as we don't have auth sorted out
@@ -87,7 +87,7 @@ def env_with_temporary_pip_target():
8787

8888

8989
@pytest.mark.slow
90-
@pytest.mark.skipif(sys.platform != "linux", reason="Linux-only test")
90+
@only_on_posix
9191
@pytest.mark.parametrize("notebook_path", filter_notebooks(list_all_notebooks(), SKIP_NOTEBOOKS))
9292
def test_notebooks_against_cirq_head(
9393
notebook_path, require_packages_not_changed, env_with_temporary_pip_target

dev_tools/requirements/deps/notebook.txt

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ ipykernel==5.3.4
88

99
# for executing notebooks in tests
1010
papermill~=2.3.2
11+
quimb~=1.6.0
1112

1213
# assumed to be part of colab
1314
seaborn~=0.11.1

0 commit comments

Comments
 (0)