Skip to content

Commit 36e91b0

Browse files
authored
Fix ci-daily notebook failures on Mac OS X (#6444)
Use common version specification for quimb and numba as defined in contrib/requirements.txt. And install notebook dependencies for all CI platforms. Avoid incompatible versions of quimb and numba in notebook environments. Example failure: https://github.com/quantumlib/Cirq/actions/runs/7792626671/job/21250976788#step:6:580 Fix verified at https://github.com/quantumlib/Cirq/actions/runs/7805446772 Related to #6336
1 parent 57c52fe commit 36e91b0

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/ci-daily.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ jobs:
3232
pip install \
3333
-r dev_tools/requirements/deps/format.txt \
3434
-r dev_tools/requirements/deps/pylint.txt \
35-
-r dev_tools/requirements/deps/pytest.txt
35+
-r dev_tools/requirements/deps/pytest.txt \
36+
-r dev_tools/requirements/deps/notebook.txt
3637
- name: Run Quil dependencies
3738
run: docker-compose -f cirq-rigetti/docker-compose.test.yaml up -d
3839
- name: Pytest check
@@ -60,7 +61,8 @@ jobs:
6061
pip install --pre cirq &&
6162
pip install -r dev_tools/requirements/deps/format.txt &&
6263
pip install -r dev_tools/requirements/deps/pylint.txt &&
63-
pip install -r dev_tools/requirements/deps/pytest.txt
64+
pip install -r dev_tools/requirements/deps/pytest.txt &&
65+
pip install -r dev_tools/requirements/deps/notebook.txt
6466
- name: Pytest Windows
6567
run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --enable-slow-tests
6668
shell: bash

dev_tools/requirements/deps/notebook.txt

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ ipykernel==5.3.4
88

99
# for executing notebooks in tests
1010
papermill~=2.3.2
11-
quimb~=1.6.0
11+
12+
# for notebooks that do `pip install cirq-core[contrib]`
13+
-r ../../../cirq-core/cirq/contrib/requirements.txt
1214

1315
# assumed to be part of colab
1416
seaborn~=0.11.1

0 commit comments

Comments
 (0)