-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Should cirq.experiments methods be at top level? #2233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think if they were at the top level then we might want "experiment" in the name. "rabi_oscillations" is not enough information on its own to describe what will happen. |
Related to #3228. While the strategy is not fully defined yet, we are moving towards the direction of moving experiments somewhere :) It might end up in its own package / distro or (I'd prefer) in ReCirq. |
I'd vote for avoiding putting them in the top-level namepsace. And, of course, when a given experiment starts getting complex it should be considered for ReCirq |
TODO:
|
@pavoljuhas This is an old issue that I am going through. Can we just answer 'no' to this question and close this issue? |
Yes, sounds like a good choice. The last addition to the top-level cirq from cirq.experiments was over 2 years ago in #4854 and we guarantee a backward compatibility for version 1.x. Outcome: Let us keep the cirq namespace as is. Let us not add any further items from cirq.experiments without a strong compelling reason. |
A bunch of them are missing from the top level
cirq
namespace, but there are some. Do we want them there or should these be incirq.experiments
?The text was updated successfully, but these errors were encountered: