Skip to content

Should cirq.experiments methods be at top level? #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dabacon opened this issue Sep 27, 2019 · 6 comments
Closed

Should cirq.experiments methods be at top level? #2233

dabacon opened this issue Sep 27, 2019 · 6 comments
Assignees
Labels
area/experiments area/packages kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@dabacon
Copy link
Collaborator

dabacon commented Sep 27, 2019

A bunch of them are missing from the top level cirq namespace, but there are some. Do we want them there or should these be in cirq.experiments?

@Strilanc
Copy link
Contributor

I think if they were at the top level then we might want "experiment" in the name. "rabi_oscillations" is not enough information on its own to describe what will happen.

@balopat
Copy link
Contributor

balopat commented Sep 2, 2020

Related to #3228. While the strategy is not fully defined yet, we are moving towards the direction of moving experiments somewhere :) It might end up in its own package / distro or (I'd prefer) in ReCirq.

@balopat balopat added area/experiments area/packages kind/health For CI/testing/release process/refactoring/technical debt items labels Sep 2, 2020
@mpharrigan
Copy link
Collaborator

I'd vote for avoiding putting them in the top-level namepsace. And, of course, when a given experiment starts getting complex it should be considered for ReCirq

@vtomole vtomole added the triage/discuss Needs decision / discussion, bring these up during Cirq Cynque label Apr 26, 2022
@95-martin-orion 95-martin-orion added triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on time/after-1.0 and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque time/before-1.0 labels Apr 27, 2022
@MichaelBroughton
Copy link
Collaborator

TODO:

  1. Determine which (if any) symbols have leaked from the module level to the top level namespace.
  2. Which of existing cirq.experiments should move to ReCirq ?

@dstrain115
Copy link
Collaborator

@pavoljuhas This is an old issue that I am going through. Can we just answer 'no' to this question and close this issue?

@pavoljuhas
Copy link
Collaborator

pavoljuhas commented Mar 22, 2024

@pavoljuhas This is an old issue that I am going through. Can we just answer 'no' to this question and close this issue?

Yes, sounds like a good choice. The last addition to the top-level cirq from cirq.experiments was over 2 years ago in #4854 and we guarantee a backward compatibility for version 1.x.

Outcome: Let us keep the cirq namespace as is. Let us not add any further items from cirq.experiments without a strong compelling reason.

@pavoljuhas pavoljuhas closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/experiments area/packages kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Development

No branches or pull requests

9 participants