Skip to content

Major goal: improve sampler interface to support batching/async #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Strilanc opened this issue Nov 13, 2019 · 4 comments
Closed

Major goal: improve sampler interface to support batching/async #2538

Strilanc opened this issue Nov 13, 2019 · 4 comments
Assignees
Labels
area/async area/batching area/samplers complexity/medium introduces/modifies 3-5 concepts, takes max up to a month for an advanced contributor kind/feature-request Describes new functionality roadmap for higher level roadmap items to capture conversations and feedback (not for project tracking) skill-level/expert One or more of the areas need deep expertise. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@Strilanc
Copy link
Contributor

No description provided.

@balopat balopat added area/async area/batching kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on labels Sep 16, 2020
@balopat
Copy link
Contributor

balopat commented Sep 16, 2020

Batching is added.
Async is still outstanding.

@balopat balopat added area/samplers complexity/medium introduces/modifies 3-5 concepts, takes max up to a month for an advanced contributor skill-level/expert One or more of the areas need deep expertise. roadmap-candidate labels Sep 16, 2020
@maffoo
Copy link
Contributor

maffoo commented Apr 8, 2022

Updates:

@dstrain115
Copy link
Collaborator

I think this goal has been achieved given maffoo's comments. We have also added a run_batch interface to engine as well. If not, we should clarify what specific things should still be added to accomplish this goal.

@maffoo
Copy link
Contributor

maffoo commented Jun 6, 2022

There are some additional things we want to add (proper async interface to Quantum Engine, "dynamic" batching that adapts based on request size, etc), but I think the sampler interface itself is in reasonable shape, so we can probably close this and address further improvements in separate issues/PRs.

@maffoo maffoo closed this as completed Jun 18, 2022
@mhucka mhucka added the roadmap for higher level roadmap items to capture conversations and feedback (not for project tracking) label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/async area/batching area/samplers complexity/medium introduces/modifies 3-5 concepts, takes max up to a month for an advanced contributor kind/feature-request Describes new functionality roadmap for higher level roadmap items to capture conversations and feedback (not for project tracking) skill-level/expert One or more of the areas need deep expertise. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Development

No branches or pull requests

6 participants