Skip to content

Upgrade automerge to version 2 of google-cloud-secret-manager #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
balopat opened this issue Feb 9, 2021 · 2 comments
Closed

Upgrade automerge to version 2 of google-cloud-secret-manager #3771

balopat opened this issue Feb 9, 2021 · 2 comments
Labels
area/cirqbot area/testing kind/health For CI/testing/release process/refactoring/technical debt items
Milestone
2025-T6: Code hea...

Comments

@balopat
Copy link
Contributor

balopat commented Feb 9, 2021

  1. We should write some tests for automerge.
  2. We should upgrade the secret manager

It looks like there's a version 2 of the google-cloud-secret-manager library available, and a migration guide: https://googleapis.dev/python/secretmanager/latest/UPGRADING.html.

Originally posted by @maffoo in #3770 (comment)
@balopat balopat added area/cirqbot kind/health For CI/testing/release process/refactoring/technical debt items area/testing labels Feb 9, 2021
@ayshiff
Copy link
Contributor

ayshiff commented Jan 4, 2025

I'd be happy to help with this.

@mhucka mhucka changed the title upgrade automerge to version 2 of google-cloud-secret-manager Upgrade automerge to version 2 of google-cloud-secret-manager Apr 1, 2025
This was referenced Apr 1, 2025
Closed
Merged
@mhucka
Copy link
Contributor

mhucka commented Apr 3, 2025

Closing because this has been resolved by #7214.

@mhucka mhucka closed this as completed Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cirqbot area/testing kind/health For CI/testing/release process/refactoring/technical debt items
Projects
Cirq 2025 roadmap
Status: Done
Milestone
2025-T6: Code health and project main...
Development

No branches or pull requests
5 participants
@balopat @mhucka @MichaelBroughton @tanujkhattar @ayshiff