FSim and PhasedFSim angles should be canonicalized between (-pi, pi] / [-pi, pi) instead of [-pi, pi] #4574
Labels
area/gates
kind/bug-report
Something doesn't seem to work.
triage/accepted
A consensus emerged that this bug report, feature request, or other action should be worked on
Description of the issue
Right now,
cirq.FSimGate
andcirq.PhasedFSimGate
canonicalize their angles between[-pi, pi]
, which was done as part of #3542.The problem with this approach is that we need to implement additional logic at the call site to check whether two instances of FSimGate are equal, instead of simply using the equality operator.
We should modify the canonicalization to be open on one of the boundaries so that the comparison at call sites can simply rely on the default value equality.
How to reproduce the issue
Cirq version
0.13.0dev
The text was updated successfully, but these errors were encountered: