Skip to content

[cirq-google] Proposal: Remove XmonDevice, Bristlecone, Foxtail and rename optimize_for_xmon. #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelBroughton opened this issue Jan 19, 2022 · 1 comment · Fixed by #4864
Labels
area/devices kind/design-issue A conversation around design triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@MichaelBroughton
Copy link
Collaborator

MichaelBroughton commented Jan 19, 2022

We haven't been using XmonDevices for a while now. We don't have any on engine either. We should probably take this opportunity to cut out XmonDevice and the two subclasses Bristlecone and Foxtail. optimized_for_xmon could also be renamed in the transfer as a part of #4722 to more accurately reflect what use cases it might have now. They are kind of cluttering up the devices story in cirq-google.

xref #4744 .

@MichaelBroughton MichaelBroughton added triage/discuss Needs decision / discussion, bring these up during Cirq Cynque kind/design-issue A conversation around design area/devices triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Jan 19, 2022
@wcourtney
Copy link
Collaborator

Related: I also filed a bug about the docs for these at b/180955395.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devices kind/design-issue A conversation around design triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants