Skip to content

Deprecate Engine.run and friends? #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpharrigan opened this issue Jun 13, 2022 · 6 comments
Closed

Deprecate Engine.run and friends? #5505

mpharrigan opened this issue Jun 13, 2022 · 6 comments
Assignees
Labels
area/google/engine kind/design-issue A conversation around design

Comments

@mpharrigan
Copy link
Collaborator

@dstrain115 : what's the plan with all the methods on Engine that aren't in AbstractEngine? I think we should deprecate them and/or modify them to delegate to EngineProcessor methods.

@mpharrigan mpharrigan added the kind/design-issue A conversation around design label Jun 13, 2022
@dstrain115
Copy link
Collaborator

I am not sure about this. There's a bunch of non-standard features, like sending to multiple processors or sending programs without jobs, etc that I am reluctant to get rid of. On the other hand, it's not great to have a bunch of methods that are not in the abstract interface.

Bringing in @wcourtney to weigh in.

@mpharrigan
Copy link
Collaborator Author

@wcourtney what do you think?

@mpharrigan
Copy link
Collaborator Author

bump @wcourtney

@mpharrigan
Copy link
Collaborator Author

@wcourtney what do you think?

@wcourtney
Copy link
Collaborator

sending to multiple processors or sending programs without jobs

2¢: As I understand it, both of these features are confusing to users. IMO, it's a user win to clean up these legacy features even if it's a bit of work to bring them back. If that happens, I expect that we'll have new requirements for the features and a new model and if there was churn in the meantime, we can skip all intermediate the migration work :-).

@dstrain115
Copy link
Collaborator

These were removed in the interface and only persist in the implementation.

Also, this is now a duplicate of #6271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/google/engine kind/design-issue A conversation around design
Projects
None yet
Development

No branches or pull requests

5 participants