-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Deprecate Engine.run and friends? #5505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am not sure about this. There's a bunch of non-standard features, like sending to multiple processors or sending programs without jobs, etc that I am reluctant to get rid of. On the other hand, it's not great to have a bunch of methods that are not in the abstract interface. Bringing in @wcourtney to weigh in. |
@wcourtney what do you think? |
bump @wcourtney |
@wcourtney what do you think? |
2¢: As I understand it, both of these features are confusing to users. IMO, it's a user win to clean up these legacy features even if it's a bit of work to bring them back. If that happens, I expect that we'll have new requirements for the features and a new model and if there was churn in the meantime, we can skip all intermediate the migration work :-). |
These were removed in the interface and only persist in the implementation. Also, this is now a duplicate of #6271 |
@dstrain115 : what's the plan with all the methods on
Engine
that aren't inAbstractEngine
? I think we should deprecate them and/or modify them to delegate toEngineProcessor
methods.The text was updated successfully, but these errors were encountered: