Skip to content

Drop support for Python 3.7 and 3.8? #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanujkhattar opened this issue Jun 22, 2023 · 9 comments
Closed

Drop support for Python 3.7 and 3.8? #6159

tanujkhattar opened this issue Jun 22, 2023 · 9 comments
Assignees
Labels
area/python kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@tanujkhattar
Copy link
Collaborator

tanujkhattar commented Jun 22, 2023

Description of the issue
We still support Python 3.7 and that prohibits us from using many convenient features in everyday implementation (see https://docs.python.org/3/whatsnew/3.8.html for a list). Python 3.7 is also soooo old now (3.8 was released in 2019!).

Should we drop support for Python 3.7? If not, till when do we continue to support Python 3.7?

Cirq version
1.2.0.dev

@tanujkhattar tanujkhattar added triage/discuss Needs decision / discussion, bring these up during Cirq Cynque kind/health For CI/testing/release process/refactoring/technical debt items python labels Jun 22, 2023
@vtomole
Copy link
Collaborator

vtomole commented Jun 22, 2023

Related #6148 (comment)

@tanujkhattar
Copy link
Collaborator Author

Ah, #6148 (comment) is a much stronger argument than my inconvenience rant (coincidentally at the same time).

I'll change my default stance now -- Let's drop support for Python 3.7 unless anyone comes and complaints. I'll wait for a week and then mark this as accepted so we can send a PR and drop support :)

@pavoljuhas
Copy link
Collaborator

pavoljuhas commented Jun 22, 2023

The question seems to have come up before - https://github.com/quantumlib/Cirq/blob/master/docs/start/install.md#python-version-support

Per https://numpy.org/neps/nep-0029-deprecation_policy.html we should be dropping 3.8 as well.

They also suggest

Minimum Python and NumPy version support should be adjusted upward on every major and minor release, but never on a patch release.

So I guess we can drop 3.7 (and maybe 3.8) in the next minor release.

@tanujkhattar
Copy link
Collaborator Author

extending support for older python versions if they are needed by Colab or internal Google systems

@pavoljuhas Do you know if colab / internal google systems need support for 3.7 or 3.8 ?

@tanujkhattar tanujkhattar changed the title Drop support for Python 3.7? Drop support for Python 3.7 and 3.8? Jun 22, 2023
@pavoljuhas
Copy link
Collaborator

@pavoljuhas Do you know if colab / internal google systems need support for 3.7 or 3.8 ?

@maffoo and I have verified they use Python 3.10.

@pavoljuhas
Copy link
Collaborator

So I guess we can drop 3.7 (and maybe 3.8) in the next minor release.

Technically we don't do patch releases, our daily wheels are pre-releases of the next minor version 1.2.0.
I think that means we can drop the support for Python 3.7, 3.8 any time, it would just get officially out with the regular release for 1.2.0.

@tanujkhattar tanujkhattar added triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Jun 26, 2023
@tanujkhattar
Copy link
Collaborator Author

tanujkhattar commented Jun 26, 2023

Looks like there are no blockers so I'll mark this issue as accepted and we can work on a PR to drop support for 3.7 and 3.8

@skushnir123
Copy link
Contributor

I can take this.

@pavoljuhas
Copy link
Collaborator

Fixed by #6167. For a complete update to Python >= 3.9 we also need #6175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/python kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Development

No branches or pull requests

5 participants