[#36582] Fix bug: TransactionalUniAsserter never fails

TransactionalUniAsserterTestMethodInvoker is a subclass of
RunOnVertxContextTestMethodInvoker.

The problem is that there were two separate pointers keeping
track of the asserter in the superclass and in the subclass.
This lead to only one pointer being initialized and, if the wrong
pointer was null-checked, the asserter was ignored causing the test
to never fail.

This commit fixes the issue by keeping only one reference to the
asserter in the superclass.

Author: DavideD

test-framework/hibernate-reactive-panache/src/main/java/io/quarkus/test/hibernate/reactive/panache/TransactionalUniAsserterTestMethodInvoker.java

@@ -8,21 +8,14 @@
 
 public class TransactionalUniAsserterTestMethodInvoker extends RunOnVertxContextTestMethodInvoker {
 
-    private UniAsserter uniAsserter;
-
     @Override
     public boolean handlesMethodParamType(String paramClassName) {
         return TransactionalUniAsserter.class.getName().equals(paramClassName);
     }
 
     @Override
-    public Object methodParamInstance(String paramClassName) {
-        if (!handlesMethodParamType(paramClassName)) {
-            throw new IllegalStateException(
-                    "TransactionalUniAsserterTestMethodInvoker does not handle '" + paramClassName + "' method param types");
-        }
-        uniAsserter = new TransactionalUniAsserter(new DefaultUniAsserter());
-        return uniAsserter;
+    protected UniAsserter createUniAsserter() {
+        return new TransactionalUniAsserter(new DefaultUniAsserter());
     }
 
     @Override

test-framework/vertx/src/main/java/io/quarkus/test/vertx/DefaultUniAsserter.java

@@ -22,6 +22,11 @@ public DefaultUniAsserter() {
         this.data = new ConcurrentHashMap<>();
     }
 
+    @Override
+    public Uni<?> asUni() {
+        return execution;
+    }
+
     @SuppressWarnings("unchecked")
     @Override
     public <T> UniAsserter assertThat(Supplier<Uni<T>> uni, Consumer<T> asserter) {

test-framework/vertx/src/main/java/io/quarkus/test/vertx/RunOnVertxContextTestMethodInvoker.java

@@ -21,7 +21,7 @@
 
 public class RunOnVertxContextTestMethodInvoker implements TestMethodInvoker {
 
-    private DefaultUniAsserter uniAsserter;
+    private UniAsserter uniAsserter;
 
     @Override
     public boolean handlesMethodParamType(String paramClassName) {
@@ -32,12 +32,16 @@ public boolean handlesMethodParamType(String paramClassName) {
     public Object methodParamInstance(String paramClassName) {
         if (!handlesMethodParamType(paramClassName)) {
             throw new IllegalStateException(
-                    "RunOnVertxContextTestMethodInvoker does not handle '" + paramClassName + "' method param types");
+                    this.getClass().getName() + " does not handle '" + paramClassName + "' method param types");
         }
-        uniAsserter = new DefaultUniAsserter();
+        uniAsserter = createUniAsserter();
         return uniAsserter;
     }
 
+    protected UniAsserter createUniAsserter() {
+        return new DefaultUniAsserter();
+    }
+
     @Override
     public boolean supportsMethod(Class<?> originalTestClass, Method originalTestMethod) {
         return hasSupportedAnnotation(originalTestClass, originalTestMethod)
@@ -152,11 +156,11 @@ public void run() {
         private final Object testInstance;
         private final Method targetMethod;
         private final List<Object> methodArgs;
-        private final DefaultUniAsserter uniAsserter;
+        private final UniAsserter uniAsserter;
         private final CompletableFuture<Object> future;
 
         public RunTestMethodOnVertxEventLoopContextHandler(Object testInstance, Method targetMethod, List<Object> methodArgs,
-                DefaultUniAsserter uniAsserter, CompletableFuture<Object> future) {
+                UniAsserter uniAsserter, CompletableFuture<Object> future) {
             this.testInstance = testInstance;
             this.future = future;
             this.targetMethod = targetMethod;
@@ -184,7 +188,7 @@ private void doRun(Runnable onTerminate) {
             try {
                 Object testMethodResult = targetMethod.invoke(testInstance, methodArgs.toArray(new Object[0]));
                 if (uniAsserter != null) {
-                    uniAsserter.execution.subscribe().with(new Consumer<Object>() {
+                    uniAsserter.asUni().subscribe().with(new Consumer<Object>() {
                         @Override
                         public void accept(Object o) {
                             onTerminate.run();
@@ -209,19 +213,16 @@ public void accept(Throwable t) {
     }
 
     public static class RunTestMethodOnVertxBlockingContextHandler implements Handler<Promise<Object>> {
-        private static final Runnable DO_NOTHING = new Runnable() {
-            @Override
-            public void run() {
-            }
+        private static final Runnable DO_NOTHING = () -> {
         };
 
         private final Object testInstance;
         private final Method targetMethod;
         private final List<Object> methodArgs;
-        private final DefaultUniAsserter uniAsserter;
+        private final UniAsserter uniAsserter;
 
         public RunTestMethodOnVertxBlockingContextHandler(Object testInstance, Method targetMethod, List<Object> methodArgs,
-                DefaultUniAsserter uniAsserter) {
+                UniAsserter uniAsserter) {
             this.testInstance = testInstance;
             this.targetMethod = targetMethod;
             this.methodArgs = methodArgs;
@@ -248,7 +249,7 @@ private void doRun(Promise<Object> promise, Runnable onTerminate) {
             try {
                 Object testMethodResult = targetMethod.invoke(testInstance, methodArgs.toArray(new Object[0]));
                 if (uniAsserter != null) {
-                    uniAsserter.execution.subscribe().with(new Consumer<Object>() {
+                    uniAsserter.asUni().subscribe().with(new Consumer<Object>() {
                         @Override
                         public void accept(Object o) {
                             onTerminate.run();

test-framework/vertx/src/main/java/io/quarkus/test/vertx/UniAsserter.java

@@ -144,4 +144,9 @@ public interface UniAsserter {
      * Clear the test data.
      */
     void clearData();
+
+    /**
+     * @return a {@link Uni} representing the operations pipeline up to this point
+     */
+    Uni<?> asUni();
 }

test-framework/vertx/src/main/java/io/quarkus/test/vertx/UniAsserterInterceptor.java

@@ -190,4 +190,8 @@ public void clearData() {
         delegate.clearData();
     }
 
+    @Override
+    public Uni<?> asUni() {
+        return delegate.asUni();
+    }
 }