Skip to content

Commit e3ab6bd

Browse files
authored
Merge pull request #44836 from sberyozkin/remove_json_in_test_security
Remove use of Json in JWT and OIDC test security
2 parents ca98b70 + 8ddbb76 commit e3ab6bd

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

test-framework/security-jwt/src/main/java/io/quarkus/test/security/jwt/JwtTestSecurityIdentityAugmentor.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package io.quarkus.test.security.jwt;
22

3+
import static io.quarkus.jsonp.JsonProviderHolder.jsonProvider;
4+
35
import java.lang.annotation.Annotation;
46
import java.util.Arrays;
57
import java.util.Collections;
68
import java.util.Map;
79
import java.util.Set;
810
import java.util.stream.Collectors;
911

10-
import jakarta.json.Json;
1112
import jakarta.json.JsonValue;
1213

1314
import org.eclipse.microprofile.jwt.Claims;
@@ -79,9 +80,9 @@ private Object wrapValue(Claim claim, Object convertedClaimValue) {
7980
Claims claimType = getClaimType(claim.key());
8081
if (Claims.UNKNOWN == claimType) {
8182
if (convertedClaimValue instanceof Long) {
82-
return Json.createValue((Long) convertedClaimValue);
83+
return jsonProvider().createValue((Long) convertedClaimValue);
8384
} else if (convertedClaimValue instanceof Integer) {
84-
return Json.createValue((Integer) convertedClaimValue);
85+
return jsonProvider().createValue((Integer) convertedClaimValue);
8586
} else if (convertedClaimValue instanceof Boolean) {
8687
return (Boolean) convertedClaimValue ? JsonValue.TRUE : JsonValue.FALSE;
8788
}

test-framework/security-oidc/src/main/java/io/quarkus/test/security/oidc/OidcTestSecurityIdentityAugmentor.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package io.quarkus.test.security.oidc;
22

3+
import static io.quarkus.jsonp.JsonProviderHolder.jsonProvider;
4+
35
import java.lang.annotation.Annotation;
46
import java.security.NoSuchAlgorithmException;
57
import java.security.PrivateKey;
@@ -8,7 +10,6 @@
810
import java.util.UUID;
911
import java.util.stream.Collectors;
1012

11-
import jakarta.json.Json;
1213
import jakarta.json.JsonArray;
1314
import jakarta.json.JsonObjectBuilder;
1415

@@ -63,10 +64,10 @@ public SecurityIdentity augment(final SecurityIdentity identity, final Annotatio
6364

6465
if (!introspectionRequired) {
6566
// JsonWebToken
66-
JsonObjectBuilder claims = Json.createObjectBuilder();
67+
JsonObjectBuilder claims = jsonProvider().createObjectBuilder();
6768
claims.add(Claims.preferred_username.name(), identity.getPrincipal().getName());
6869
claims.add(Claims.groups.name(),
69-
Json.createArrayBuilder(identity.getRoles().stream().collect(Collectors.toList())).build());
70+
jsonProvider().createArrayBuilder(identity.getRoles().stream().collect(Collectors.toList())).build());
7071
if (oidcSecurity != null && oidcSecurity.claims() != null) {
7172
for (Claim claim : oidcSecurity.claims()) {
7273
Object claimValue = convertClaimValue(claim);
@@ -99,7 +100,7 @@ public SecurityIdentity augment(final SecurityIdentity identity, final Annotatio
99100
builder.addCredential(idToken);
100101
builder.addCredential(accessToken);
101102
} else {
102-
JsonObjectBuilder introspectionBuilder = Json.createObjectBuilder();
103+
JsonObjectBuilder introspectionBuilder = jsonProvider().createObjectBuilder();
103104
introspectionBuilder.add(OidcConstants.INTROSPECTION_TOKEN_ACTIVE, true);
104105
introspectionBuilder.add(OidcConstants.INTROSPECTION_TOKEN_USERNAME, identity.getPrincipal().getName());
105106
introspectionBuilder.add(OidcConstants.TOKEN_SCOPE,
@@ -118,7 +119,7 @@ public SecurityIdentity augment(final SecurityIdentity identity, final Annotatio
118119

119120
// UserInfo
120121
if (oidcSecurity != null && oidcSecurity.userinfo() != null) {
121-
JsonObjectBuilder userInfoBuilder = Json.createObjectBuilder();
122+
JsonObjectBuilder userInfoBuilder = jsonProvider().createObjectBuilder();
122123
for (UserInfo userinfo : oidcSecurity.userinfo()) {
123124
userInfoBuilder.add(userinfo.key(), userinfo.value());
124125
}

0 commit comments

Comments
 (0)