Closes #3220 (#3226)

Be more robust in case of bad URIs.

Author: cscheid

news/changelog-1.3.md

@@ -21,3 +21,4 @@
 ## Miscellaneous
 
 - Work around pandoc strict checking of `number-offset` type. ([#3126](https://github.com/quarto-dev/quarto-cli/issues/3126))
+- Warn instead of crash on bad URI ([#3220](https://github.com/quarto-dev/quarto-cli/issues/3220))

src/core/html.ts

@@ -11,6 +11,7 @@ import { pandocAutoIdentifier } from "./pandoc/pandoc-id.ts";
 import { isFileRef } from "./http.ts";
 import { cssFileRefs } from "./css.ts";
 import { HtmlPostProcessResult } from "../command/render/types.ts";
+import { warning } from "log/mod.ts";
 
 export function asHtmlId(text: string) {
   return pandocAutoIdentifier(text, false);
@@ -19,7 +20,18 @@ export function asHtmlId(text: string) {
 export function getDecodedAttribute(element: Element, attrib: string) {
   const value = element.getAttribute(attrib);
   if (value) {
-    return decodeURI(value);
+    try {
+      return decodeURI(value);
+    } catch (e) {
+      if (e instanceof URIError) {
+        warning(
+          `Invalid URI '${value}' in attribute '${attrib}' of element '${element.tagName}'`,
+        );
+        return value;
+      } else {
+        throw e;
+      }
+    }
   } else {
     return value;
   }

src/resources/editor/tools/vs-code.mjs

@@ -16437,48 +16437,6 @@ var require_yaml_intelligence_resources = __commonJS({
           description: "The alt text for preview image on this page."
         }
       ],
-      "schema/extension.yml": [
-        {
-          name: "title",
-          description: "Extension title.",
-          schema: "string"
-        },
-        {
-          name: "author",
-          description: "Extension author.",
-          schema: "string"
-        },
-        {
-          name: "version",
-          description: "Extension version.",
-          schema: {
-            ref: "semver"
-          }
-        },
-        {
-          name: "quarto-required",
-          description: "Quarto version range. See https://docs.npmjs.com/cli/v6/using-npm/semver for syntax details.",
-          schema: "string"
-        },
-        {
-          name: "contributes",
-          schema: {
-            object: {
-              properties: {
-                shortcodes: {
-                  arrayOf: "path"
-                },
-                filters: {
-                  arrayOf: "path"
-                },
-                formats: {
-                  schema: "object"
-                }
-              }
-            }
-          }
-        }
-      ],
       "schema/format-aliases.yml": {
         aliases: {
           "epub-all": [
@@ -20139,7 +20097,49 @@ var require_yaml_intelligence_resources = __commonJS({
           ]
         },
         $id: "handlers/mermaid"
-      }
+      },
+      "schema/extension.yml": [
+        {
+          name: "title",
+          description: "Extension title.",
+          schema: "string"
+        },
+        {
+          name: "author",
+          description: "Extension author.",
+          schema: "string"
+        },
+        {
+          name: "version",
+          description: "Extension version.",
+          schema: {
+            ref: "semver"
+          }
+        },
+        {
+          name: "quarto-required",
+          description: "Quarto version range. See https://docs.npmjs.com/cli/v6/using-npm/semver for syntax details.",
+          schema: "string"
+        },
+        {
+          name: "contributes",
+          schema: {
+            object: {
+              properties: {
+                shortcodes: {
+                  arrayOf: "path"
+                },
+                filters: {
+                  arrayOf: "path"
+                },
+                formats: {
+                  schema: "object"
+                }
+              }
+            }
+          }
+        }
+      ]
     };
   }
 });

src/resources/editor/tools/yaml/web-worker.js

@@ -9413,48 +9413,6 @@
       "description": "The alt text for preview image on this page."
     }
   ],
-  "schema/extension.yml": [
-    {
-      "name": "title",
-      "description": "Extension title.",
-      "schema": "string"
-    },
-    {
-      "name": "author",
-      "description": "Extension author.",
-      "schema": "string"
-    },
-    {
-      "name": "version",
-      "description": "Extension version.",
-      "schema": {
-        "ref": "semver"
-      }
-    },
-    {
-      "name": "quarto-required",
-      "description": "Quarto version range. See https://docs.npmjs.com/cli/v6/using-npm/semver for syntax details.",
-      "schema": "string"
-    },
-    {
-      "name": "contributes",
-      "schema": {
-        "object": {
-          "properties": {
-            "shortcodes": {
-              "arrayOf": "path"
-            },
-            "filters": {
-              "arrayOf": "path"
-            },
-            "formats": {
-              "schema": "object"
-            }
-          }
-        }
-      }
-    }
-  ],
   "schema/format-aliases.yml": {
     "aliases": {
       "epub-all": [
@@ -13115,5 +13073,47 @@
       ]
     },
     "$id": "handlers/mermaid"
-  }
+  },
+  "schema/extension.yml": [
+    {
+      "name": "title",
+      "description": "Extension title.",
+      "schema": "string"
+    },
+    {
+      "name": "author",
+      "description": "Extension author.",
+      "schema": "string"
+    },
+    {
+      "name": "version",
+      "description": "Extension version.",
+      "schema": {
+        "ref": "semver"
+      }
+    },
+    {
+      "name": "quarto-required",
+      "description": "Quarto version range. See https://docs.npmjs.com/cli/v6/using-npm/semver for syntax details.",
+      "schema": "string"
+    },
+    {
+      "name": "contributes",
+      "schema": {
+        "object": {
+          "properties": {
+            "shortcodes": {
+              "arrayOf": "path"
+            },
+            "filters": {
+              "arrayOf": "path"
+            },
+            "formats": {
+              "schema": "object"
+            }
+          }
+        }
+      }
+    }
+  ]
 }