Skip to content

Commit 1fbe92c

Browse files
enkeyzenkeyz
authored
fixed capitalization of subtest names (#550)
* fixed capitalization of subtests * also fixed in the diff versions
1 parent 570e6d9 commit 1fbe92c

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

‎pointers-and-errors.md

+13-13
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ Pretty much the opposite of `Deposit()`
268268
```go
269269
func TestWallet(t *testing.T) {
270270

271-
t.Run("Deposit", func(t *testing.T) {
271+
t.Run("deposit", func(t *testing.T) {
272272
wallet := Wallet{}
273273

274274
wallet.Deposit(Bitcoin(10))
@@ -282,7 +282,7 @@ func TestWallet(t *testing.T) {
282282
}
283283
})
284284

285-
t.Run("Withdraw", func(t *testing.T) {
285+
t.Run("withdraw", func(t *testing.T) {
286286
wallet := Wallet{balance: Bitcoin(20)}
287287

288288
wallet.Withdraw(Bitcoin(10))
@@ -336,13 +336,13 @@ func TestWallet(t *testing.T) {
336336
}
337337
}
338338

339-
t.Run("Deposit", func(t *testing.T) {
339+
t.Run("deposit", func(t *testing.T) {
340340
wallet := Wallet{}
341341
wallet.Deposit(Bitcoin(10))
342342
assertBalance(t, wallet, Bitcoin(10))
343343
})
344344

345-
t.Run("Withdraw", func(t *testing.T) {
345+
t.Run("withdraw", func(t *testing.T) {
346346
wallet := Wallet{balance: Bitcoin(20)}
347347
wallet.Withdraw(Bitcoin(10))
348348
assertBalance(t, wallet, Bitcoin(10))
@@ -362,7 +362,7 @@ Let's try this out in a test.
362362
## Write the test first
363363

364364
```go
365-
t.Run("Withdraw insufficient funds", func(t *testing.T) {
365+
t.Run("withdraw insufficient funds", func(t *testing.T) {
366366
startingBalance := Bitcoin(20)
367367
wallet := Wallet{startingBalance}
368368
err := wallet.Withdraw(Bitcoin(100))
@@ -434,7 +434,7 @@ assertError := func(t testing.TB, err error) {
434434
And in our test
435435

436436
```go
437-
t.Run("Withdraw insufficient funds", func(t *testing.T) {
437+
t.Run("withdraw insufficient funds", func(t *testing.T) {
438438
startingBalance := Bitcoin(20)
439439
wallet := Wallet{startingBalance}
440440
err := wallet.Withdraw(Bitcoin(100))
@@ -468,7 +468,7 @@ assertError := func(t testing.TB, got error, want string) {
468468
And then update the caller
469469

470470
```go
471-
t.Run("Withdraw insufficient funds", func(t *testing.T) {
471+
t.Run("withdraw insufficient funds", func(t *testing.T) {
472472
startingBalance := Bitcoin(20)
473473
wallet := Wallet{startingBalance}
474474
err := wallet.Withdraw(Bitcoin(100))
@@ -529,19 +529,19 @@ Next we can refactor our test code to use this value instead of specific strings
529529
```go
530530
func TestWallet(t *testing.T) {
531531

532-
t.Run("Deposit", func(t *testing.T) {
532+
t.Run("deposit", func(t *testing.T) {
533533
wallet := Wallet{}
534534
wallet.Deposit(Bitcoin(10))
535535
assertBalance(t, wallet, Bitcoin(10))
536536
})
537537

538-
t.Run("Withdraw with funds", func(t *testing.T) {
538+
t.Run("withdraw with funds", func(t *testing.T) {
539539
wallet := Wallet{Bitcoin(20)}
540540
wallet.Withdraw(Bitcoin(10))
541541
assertBalance(t, wallet, Bitcoin(10))
542542
})
543543

544-
t.Run("Withdraw insufficient funds", func(t *testing.T) {
544+
t.Run("withdraw insufficient funds", func(t *testing.T) {
545545
wallet := Wallet{Bitcoin(20)}
546546
err := wallet.Withdraw(Bitcoin(100))
547547

@@ -598,22 +598,22 @@ Here is the final test code that accounts for this.
598598
```go
599599
func TestWallet(t *testing.T) {
600600

601-
t.Run("Deposit", func(t *testing.T) {
601+
t.Run("deposit", func(t *testing.T) {
602602
wallet := Wallet{}
603603
wallet.Deposit(Bitcoin(10))
604604

605605
assertBalance(t, wallet, Bitcoin(10))
606606
})
607607

608-
t.Run("Withdraw with funds", func(t *testing.T) {
608+
t.Run("withdraw with funds", func(t *testing.T) {
609609
wallet := Wallet{Bitcoin(20)}
610610
err := wallet.Withdraw(Bitcoin(10))
611611

612612
assertNoError(t, err)
613613
assertBalance(t, wallet, Bitcoin(10))
614614
})
615615

616-
t.Run("Withdraw insufficient funds", func(t *testing.T) {
616+
t.Run("withdraw insufficient funds", func(t *testing.T) {
617617
wallet := Wallet{Bitcoin(20)}
618618
err := wallet.Withdraw(Bitcoin(100))
619619

‎pointers/v2/wallet_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ func TestWallet(t *testing.T) {
1515
}
1616
}
1717

18-
t.Run("Deposit", func(t *testing.T) {
18+
t.Run("deposit", func(t *testing.T) {
1919
wallet := Wallet{}
2020
wallet.Deposit(Bitcoin(10))
2121
assertBalance(t, wallet, Bitcoin(10))
2222
})
2323

24-
t.Run("Withdraw", func(t *testing.T) {
24+
t.Run("withdraw", func(t *testing.T) {
2525
wallet := Wallet{balance: Bitcoin(20)}
2626
wallet.Withdraw(10)
2727
assertBalance(t, wallet, Bitcoin(10))

‎pointers/v3/wallet_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,21 @@ func TestWallet(t *testing.T) {
2222
}
2323
}
2424

25-
t.Run("Deposit", func(t *testing.T) {
25+
t.Run("deposit", func(t *testing.T) {
2626
wallet := Wallet{}
2727
wallet.Deposit(Bitcoin(10))
2828

2929
assertBalance(t, wallet, Bitcoin(10))
3030
})
3131

32-
t.Run("Withdraw with funds", func(t *testing.T) {
32+
t.Run("withdraw with funds", func(t *testing.T) {
3333
wallet := Wallet{Bitcoin(20)}
3434
wallet.Withdraw(Bitcoin(10))
3535

3636
assertBalance(t, wallet, Bitcoin(10))
3737
})
3838

39-
t.Run("Withdraw insufficient funds", func(t *testing.T) {
39+
t.Run("withdraw insufficient funds", func(t *testing.T) {
4040
startingBalance := Bitcoin(20)
4141
wallet := Wallet{startingBalance}
4242
err := wallet.Withdraw(Bitcoin(100))

‎pointers/v4/wallet_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,22 @@ import (
66

77
func TestWallet(t *testing.T) {
88

9-
t.Run("Deposit", func(t *testing.T) {
9+
t.Run("deposit", func(t *testing.T) {
1010
wallet := Wallet{}
1111
wallet.Deposit(Bitcoin(10))
1212

1313
assertBalance(t, wallet, Bitcoin(10))
1414
})
1515

16-
t.Run("Withdraw with funds", func(t *testing.T) {
16+
t.Run("withdraw with funds", func(t *testing.T) {
1717
wallet := Wallet{Bitcoin(20)}
1818
err := wallet.Withdraw(Bitcoin(10))
1919

2020
assertBalance(t, wallet, Bitcoin(10))
2121
assertNoError(t, err)
2222
})
2323

24-
t.Run("Withdraw insufficient funds", func(t *testing.T) {
24+
t.Run("withdraw insufficient funds", func(t *testing.T) {
2525
startingBalance := Bitcoin(20)
2626
wallet := Wallet{startingBalance}
2727
err := wallet.Withdraw(Bitcoin(100))

0 commit comments

Comments
 (0)