-
Notifications
You must be signed in to change notification settings - Fork 367
Load third party JS using async #444
Comments
for raven specifically, this looks like it may be tricky, since setting it to async means we don't get errors during loading. see this for more details: getsentry/sentry-javascript#169 |
Yeah kinda felt that would be an issue, especially Google Analytics and Mixpanel. Maybe we can bundle raven/mixpanel as part of our javascript, if anything to save on http calls. @mmahalwy thoughts on bundling raven. |
I am not sure if webpack has the ability to download/bundle unless we download them. I think we could load raven in sync but don't need mixpanel to be. |
Okay seems that mixpanel and zendesk load their script via |
@mmahalwy They're being downloaded before DOM is ready? We can download the files locally and bundle them as part of our script. |
no no i mean it's a script from them that embeds their script async |
Uh oh!
There was an error while loading. Please reload this page.
I ran webpagetest[1] against the website and we have some things to improve around
time to first byte
.<script src="https://cdn.ravenjs.com/3.0.4/raven.min.js" async ></script>
1.https://www.webpagetest.org/result/160811_AY_9BP/
The text was updated successfully, but these errors were encountered: