Remove unnecessary requeue

ChunyiLyu · ChunyiLyu · commit 00b5c53e034a · 2020-09-30T17:25:44.000+01:00
- if no error was returned after defaulting, the
controller can move on to reconcile the object, there
is no need to requeue the request again
diff --git a/controllers/rabbitmqcluster_controller.go b/controllers/rabbitmqcluster_controller.go
@@ -107,8 +107,6 @@ func (r *RabbitmqClusterReconciler) Reconcile(req ctrl.Request) (ctrl.Result, er
 		if err := r.Client.Update(ctx, rabbitmqCluster); err != nil {
 			return ctrl.Result{}, err
 		}
-		// TODO do we need to requeue?
-		return ctrl.Result{Requeue: true}, nil
 	}
 
 	// Resource has been marked for deletion

Original file line number	Diff line number	Diff line change
`@@ -107,8 +107,6 @@ func (r *RabbitmqClusterReconciler) Reconcile(req ctrl.Request) (ctrl.Result, er`
`107`	`107`	`if err := r.Client.Update(ctx, rabbitmqCluster); err != nil {`
`108`	`108`	`return ctrl.Result{}, err`
`109`	`109`	`}`
`110`		`- // TODO do we need to requeue?`
`111`		`- return ctrl.Result{Requeue: true}, nil`
`112`	`110`	`}`
`113`	`111`
`114`	`112`	`// Resource has been marked for deletion`