Add make smoke-test target

- separate out a single 'smoke-test' from our system tests

[#170954291]

Co-authored-by: Jonathan Tsang <[email protected]>

Author: ChunyiLyu

Diff for: Makefile

@@ -150,9 +150,12 @@ kind-unprepare:  ## Remove KIND support for LoadBalancer services, and local-pat
 	@kubectl delete -f https://raw.githubusercontent.com/pivotal-k8s/kind-on-c/master/metallb-cm.yaml
 	@kubectl delete -f https://raw.githubusercontent.com/danderson/metallb/v0.8.1/manifests/metallb.yaml
 
-system-tests:  ## Run system tests
+system-tests:
 	NAMESPACE="pivotal-rabbitmq-system" ginkgo -nodes=3 --randomizeAllSpecs -r system_tests/
 
+smoke-test:
+	NAMESPACE="pivotal-rabbitmq-system" ginkgo --focus="Publish and consume a message" -r system_tests/
+
 DOCKER_REGISTRY_SECRET=p-rmq-registry-access
 DOCKER_REGISTRY_SERVER=registry.pivotal.io
 DOCKER_REGISTRY_USERNAME_LOCAL=$(shell lpassd show "Shared-RabbitMQ for Kubernetes/pivnet-registry-ci" --notes | jq -r .name)

Diff for: system_tests/system_tests.go

@@ -16,11 +16,9 @@ import (
 )
 
 const (
-	podCreationTimeout     = 360 * time.Second
-	serviceCreationTimeout = 10 * time.Second
-	ingressServiceSuffix   = "ingress"
-	statefulSetSuffix      = "server"
-	configMapSuffix        = "server-conf"
+	podCreationTimeout   = 360 * time.Second
+	ingressServiceSuffix = "ingress"
+	statefulSetSuffix    = "server"
 )
 
 var _ = Describe("Operator", func() {
@@ -35,7 +33,7 @@ var _ = Describe("Operator", func() {
 		Expect(err).NotTo(HaveOccurred())
 	})
 
-	Context("Initial RabbitmqCluster setup", func() {
+	Context("Publish and consume a message", func() {
 		var (
 			cluster  *rabbitmqv1beta1.RabbitmqCluster
 			hostname string
@@ -92,30 +90,46 @@ var _ = Describe("Operator", func() {
 
 				Expect(err).NotTo(HaveOccurred())
 			})
+		})
+	})
 
-			By("publishing a message", func() {
-				err := rabbitmqPublishToNewQueue(hostname, username, password)
-				Expect(err).NotTo(HaveOccurred())
-			})
+	Context("Persistence", func() {
+		var (
+			cluster  *rabbitmqv1beta1.RabbitmqCluster
+			hostname string
+			username string
+			password string
+		)
 
-			By("updating the CR status correctly", func() {
-				Expect(clientSet.CoreV1().Pods(namespace).Delete(statefulSetPodName(cluster, 0), &metav1.DeleteOptions{})).NotTo(HaveOccurred())
+		BeforeEach(func() {
+			cluster = generateRabbitmqCluster(namespace, "persistence-rabbit")
+			cluster.Spec.Service.Type = "LoadBalancer"
+			cluster.Spec.Image = "registry.pivotal.io/p-rabbitmq-for-kubernetes-staging/rabbitmq:latest"
+			cluster.Spec.ImagePullSecret = "p-rmq-registry-access"
+			cluster.Spec.Resources = &corev1.ResourceRequirements{
+				Requests: map[corev1.ResourceName]k8sresource.Quantity{},
+				Limits:   map[corev1.ResourceName]k8sresource.Quantity{},
+			}
+			Expect(createRabbitmqCluster(rmqClusterClient, cluster)).NotTo(HaveOccurred())
 
-				Eventually(func() []byte {
-					output, err := kubectl(
-						"-n",
-						cluster.Namespace,
-						"get",
-						"rabbitmqclusters",
-						cluster.Name,
-						"-o=jsonpath='{.status.clusterStatus}'",
-					)
-					Expect(err).NotTo(HaveOccurred())
-					return output
+			waitForRabbitmqRunning(cluster)
 
-				}, 20, 1).Should(ContainSubstring("created"))
+			hostname = rabbitmqHostname(clientSet, cluster)
 
-				waitForRabbitmqRunning(cluster)
+			var err error
+			username, password, err = getRabbitmqUsernameAndPassword(clientSet, cluster.Namespace, cluster.Name)
+			Expect(err).NotTo(HaveOccurred())
+			assertHttpReady(hostname)
+		})
+
+		AfterEach(func() {
+			Expect(rmqClusterClient.Delete(context.TODO(), cluster)).To(Succeed())
+		})
+
+		It("persists messages after pod deletion", func() {
+			By("publishing a message", func() {
+				err := rabbitmqPublishToNewQueue(hostname, username, password)
+				Expect(err).NotTo(HaveOccurred())
 			})
 
 			By("consuming a message after RabbitMQ was restarted", func() {