Rename port http to management in service

Author: ChunyiLyu

controllers/rabbitmqcluster_controller_test.go

@@ -1067,7 +1067,7 @@ var _ = Describe("RabbitmqClusterController", func() {
 					TargetPort: amqpTargetPort,
 				},
 				corev1.ServicePort{
-					Name:       "http",
+					Name:       "management",
 					Port:       15672,
 					Protocol:   corev1.ProtocolTCP,
 					TargetPort: managementTargetPort,

internal/resource/service.go

@@ -117,11 +117,11 @@ func (builder *ServiceBuilder) updatePorts(servicePorts []corev1.ServicePort) []
 			TargetPort: intstr.FromInt(5672),
 			Name:       "amqp",
 		},
-		"http": {
+		"management": {
 			Protocol:   corev1.ProtocolTCP,
 			Port:       15672,
 			TargetPort: intstr.FromInt(15672),
-			Name:       "http",
+			Name:       "management",
 		},
 	}
 	if builder.Instance.AdditionalPluginEnabled("rabbitmq_mqtt") {

internal/resource/service_test.go

@@ -393,13 +393,13 @@ var _ = Context("Services", func() {
 					TargetPort: intstr.FromInt(5672),
 					Protocol:   corev1.ProtocolTCP,
 				}
-				httpPort := corev1.ServicePort{
-					Name:       "http",
+				managementPort := corev1.ServicePort{
+					Name:       "management",
 					Port:       15672,
 					TargetPort: intstr.FromInt(15672),
 					Protocol:   corev1.ProtocolTCP,
 				}
-				Expect(svc.Spec.Ports).To(ConsistOf(amqpPort, httpPort))
+				Expect(svc.Spec.Ports).To(ConsistOf(amqpPort, managementPort))
 			})
 
 			DescribeTable("plugins exposing ports",
@@ -444,7 +444,7 @@ var _ = Context("Services", func() {
 					{
 						Protocol:   corev1.ProtocolTCP,
 						Port:       15672,
-						Name:       "http",
+						Name:       "management",
 						TargetPort: intstr.FromInt(15672),
 						NodePort:   1234,
 					},
@@ -461,16 +461,16 @@ var _ = Context("Services", func() {
 					TargetPort: intstr.FromInt(5672),
 					NodePort:   12345,
 				}
-				expectedHTTPServicePort := corev1.ServicePort{
+				expectedManagementServicePort := corev1.ServicePort{
 					Protocol:   corev1.ProtocolTCP,
 					Port:       15672,
-					Name:       "http",
+					Name:       "management",
 					TargetPort: intstr.FromInt(15672),
 					NodePort:   1234,
 				}
 
 				Expect(svc.Spec.Ports).To(ContainElement(expectedAmqpServicePort))
-				Expect(svc.Spec.Ports).To(ContainElement(expectedHTTPServicePort))
+				Expect(svc.Spec.Ports).To(ContainElement(expectedManagementServicePort))
 			})
 
 			It("unsets nodePort after updating from NodePort to ClusterIP", func() {
@@ -614,7 +614,7 @@ var _ = Context("Services", func() {
 						Protocol:   corev1.ProtocolTCP,
 					},
 					corev1.ServicePort{
-						Name:       "http",
+						Name:       "management",
 						Port:       15672,
 						TargetPort: intstr.FromInt(15672),
 						Protocol:   corev1.ProtocolTCP,

system_tests/system_tests.go

@@ -49,7 +49,7 @@ var _ = Describe("Operator", func() {
 			waitForRabbitmqRunning(cluster)
 
 			hostname = kubernetesNodeIp(ctx, clientSet)
-			port = rabbitmqNodePort(ctx, clientSet, cluster, "http")
+			port = rabbitmqNodePort(ctx, clientSet, cluster, "management")
 
 			var err error
 			username, password, err = getUsernameAndPassword(ctx, clientSet, cluster.Namespace, cluster.Name)
@@ -249,7 +249,7 @@ CONSOLE_LOG=new`
 			waitForRabbitmqRunning(cluster)
 
 			hostname = kubernetesNodeIp(ctx, clientSet)
-			port = rabbitmqNodePort(ctx, clientSet, cluster, "http")
+			port = rabbitmqNodePort(ctx, clientSet, cluster, "management")
 
 			var err error
 			username, password, err = getUsernameAndPassword(ctx, clientSet, cluster.Namespace, cluster.Name)
@@ -309,7 +309,7 @@ CONSOLE_LOG=new`
 			It("works", func() {
 				username, password, err := getUsernameAndPassword(ctx, clientSet, cluster.Namespace, cluster.Name)
 				hostname := kubernetesNodeIp(ctx, clientSet)
-				port := rabbitmqNodePort(ctx, clientSet, cluster, "http")
+				port := rabbitmqNodePort(ctx, clientSet, cluster, "management")
 				Expect(err).NotTo(HaveOccurred())
 				assertHttpReady(hostname, port)