@@ -103,28 +103,27 @@ func (r *RabbitmqClusterReconciler) Reconcile(req ctrl.Request) (ctrl.Result, er
103
103
return ctrl.Result {}, nil
104
104
}
105
105
106
- // Resource has been marked for deletion
106
+ // Check if the resource has been marked for deletion
107
107
if ! rabbitmqCluster .ObjectMeta .DeletionTimestamp .IsZero () {
108
108
logger .Info ("Deleting RabbitmqCluster" ,
109
109
"namespace" , rabbitmqCluster .Namespace ,
110
110
"name" , rabbitmqCluster .Name )
111
- // Stop reconciliation as the item is being deleted
112
111
return ctrl.Result {}, r .prepareForDeletion (ctx , rabbitmqCluster )
113
112
}
114
113
114
+ // Ensure the resource have a deletion marker
115
+ if err := r .addFinalizerIfNeeded (ctx , rabbitmqCluster ); err != nil {
116
+ return ctrl.Result {}, err
117
+ }
118
+
115
119
// TLS: check if specified, and if secret exists
116
120
if rabbitmqCluster .TLSEnabled () {
117
121
if result , err := r .checkTLSSecrets (ctx , rabbitmqCluster ); err != nil {
118
122
return result , err
119
123
}
120
124
}
121
125
122
- if err := r .addFinalizerIfNeeded (ctx , rabbitmqCluster ); err != nil {
123
- return ctrl.Result {}, err
124
- }
125
-
126
126
childResources , err := r .getChildResources (ctx , * rabbitmqCluster )
127
-
128
127
if err != nil {
129
128
return ctrl.Result {}, err
130
129
}
@@ -600,8 +599,8 @@ func (r *RabbitmqClusterReconciler) addRabbitmqDeletionLabel(ctx context.Context
600
599
return nil
601
600
}
602
601
602
+ // addFinalizerIfNeeded adds a deletion finalizer if the RabbitmqCluster does not have one yet and is not marked for deletion
603
603
func (r * RabbitmqClusterReconciler ) addFinalizerIfNeeded (ctx context.Context , rabbitmqCluster * rabbitmqv1beta1.RabbitmqCluster ) error {
604
- // The RabbitmqCluster is not marked for deletion (no deletion timestamp) but does not have the deletion finalizer
605
604
if rabbitmqCluster .ObjectMeta .DeletionTimestamp .IsZero () && ! controllerutil .ContainsFinalizer (rabbitmqCluster , deletionFinalizer ) {
606
605
controllerutil .AddFinalizer (rabbitmqCluster , deletionFinalizer )
607
606
if err := r .Client .Update (ctx , rabbitmqCluster ); err != nil {
0 commit comments