Remove redundent and wrong assertion

- the expect assertion on length of imagePullSecrets is in
an eventually but not the returned result, which means that
the 3 seconds timeout does not apply and when failed at the
first iteration the assertion will just fail. While waiting
for the statefulSet to update, this could be very flaky on a
bad day
- the assertion itself is also redundent, as "ConsistOf" is
an exact matcher so the length is asserted already.

Author: ChunyiLyu

controllers/rabbitmqcluster_controller_test.go

@@ -716,7 +716,6 @@ var _ = Describe("RabbitmqClusterController", func() {
 			Eventually(func() []corev1.LocalObjectReference {
 				stsName := cluster.ChildResourceName("server")
 				sts, _ := clientSet.AppsV1().StatefulSets(cluster.Namespace).Get(ctx, stsName, metav1.GetOptions{})
-				Expect(len(sts.Spec.Template.Spec.ImagePullSecrets)).To(Equal(1))
 				return sts.Spec.Template.Spec.ImagePullSecrets
 			}, 3).Should(ConsistOf(corev1.LocalObjectReference{Name: "my-new-secret"}))
 		})