Skip to content

Better solution for updating configurations #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChunyiLyu opened this issue Jul 27, 2020 · 0 comments · Fixed by #394
Closed

Better solution for updating configurations #225

ChunyiLyu opened this issue Jul 27, 2020 · 0 comments · Fixed by #394
Assignees
Labels
enhancement New feature or request

Comments

@ChunyiLyu
Copy link
Contributor

Is your feature request related to a problem? Please describe.

At the moment, the controller uses configMap update as the signal to decide to trigger a statefulSet restart. This approach is very cheap, but has it's downside. If the statefulSet restart was not successful at first reconcile time, even if we requeue the same request, configMap no long needs an update and the controller will not try to restart the statefulSet. We need a better solution so that the restart can be trigger reliably.

@ChunyiLyu ChunyiLyu added the enhancement New feature or request label Jul 27, 2020
@ChunyiLyu ChunyiLyu self-assigned this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant