Skip to content

Log resource limits in kiB, MiB, GiB (as those are the limits we and other tools actually use) #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcorbacho opened this issue May 26, 2017 · 1 comment

Comments

@dcorbacho
Copy link
Contributor

dcorbacho commented May 26, 2017

When we do conversions to MB inside vm_memory_monitor we use 1 MiB (1048576 bytes), as in the log messages. But when we convert values such as the high watermark, we use 1MB (1000000 bytes).

Detected while testing #1224

@michaelklishin
Copy link
Collaborator

It should be noted that /proc/meminfo actually reports values in mebibytes/kibibytes according to RHEL documentation.

Therefore the use of each value should be analysed on a case by case basis.

@michaelklishin michaelklishin changed the title Mismatch of MB conversion in memory monitor Switch to kB, MB, GB (as opposed to kiB, MiB, GiB) in vm_memory_monitor where possible May 26, 2017
@michaelklishin michaelklishin added this to the 3.6.11 milestone Jun 6, 2017
@michaelklishin michaelklishin changed the title Switch to kB, MB, GB (as opposed to kiB, MiB, GiB) in vm_memory_monitor where possible Log resource limits in kiB, MiB, GiB (as those are the limits we and other tools actually use) Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants