Skip to content

Commit 07c835a

Browse files
committed
Fix DB rollback when reversable add_column has several options. #359.
1 parent bfcc993 commit 07c835a

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,23 @@
11

2+
## v4.2.5
3+
4+
#### Fixed
5+
6+
* DB rollback when reversable add_column has several options. Fixes #359
7+
8+
29
## v4.2.4
310

11+
#### Fixed
12+
413
* Compatible with Rails 4.2.1.
514
* Fix schema limit reflection for char/varchar. Fixes #394.
615

716

817
## v4.2.3
918

19+
#### Fixed
20+
1021
* Fix SET defaults when using Azure.
1122
* Test insert 4-byte unicode chars.
1223
* Make rollback transaction transcount aware for implicit error rollbacks. Fixes #390

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def rename_table(table_name, new_name)
6060
rename_table_indexes(table_name, new_name)
6161
end
6262

63-
def remove_column(table_name, column_name, _type = nil)
63+
def remove_column(table_name, column_name, type = nil, options = {})
6464
raise ArgumentError.new('You must specify at least one column name. Example: remove_column(:people, :first_name)') if column_name.is_a? Array
6565
remove_check_constraints(table_name, column_name)
6666
remove_default_constraint(table_name, column_name)

0 commit comments

Comments
 (0)