Added documentation on how to mitigate CVE-2015-9284. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kratob
approved these changes
Mar 10, 2021
Co-authored-by: Tobias Kraze <[email protected]>
n00dle
reviewed
Mar 10, 2021
…ks to @n00dle. Co-authored-by: n00dle <[email protected]>
sikachu
approved these changes
Mar 10, 2021
marvinthepa
reviewed
Mar 10, 2021
| @@ -109,7 +109,30 @@ MyLogger.send :include, ActiveRecord::SessionStore::Extension::LoggerSilencer | |||
| This silencer is being used to silence the logger and not leaking private | |||
| information into the log, and it is required for security reason. | |||
|
|
|||
| ## Contributing to Active Record Session Store | |||
| CVE-2015-9284 mitigation | |||
There was a problem hiding this comment.
@thorsteneckel was this just a mistake or does CVE-2015-9284 have any connection to CVE-2019-25025 ?
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @sikachu in #151 I added a block to the README on how to mitigate CVE-2015-9284 by converting insecurely stored session IDs by running an Active Record Migration including an example and remark for custom Session classes.
cc @rafaelfranca