Skip to content

Commit 8429874

Browse files
authored
Return false in production environments (#1179)
1 parent f74f531 commit 8429874

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
**Please note that Webpacker 3.1.0 and 3.1.1 has some serious bugs so please consider using either 3.0.2 or 3.2.0**
22

3+
## [Unreleased]
4+
5+
- Disable dev server running? check if no dev server config is present in that environment [#1179](https://github.com/rails/webpacker/pull/1179)
6+
37
## [3.2.0] - 2017-12-16
48

59
### To upgrade:

lib/webpacker/dev_server.rb

+6-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,12 @@ def initialize(webpacker)
1010
end
1111

1212
def running?
13-
Socket.tcp(host, port, connect_timeout: connect_timeout).close
14-
true
13+
if config.dev_server.present?
14+
Socket.tcp(host, port, connect_timeout: connect_timeout).close
15+
true
16+
else
17+
false
18+
end
1519
rescue
1620
false
1721
end

test/dev_server_test.rb

+7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
require "test_helper"
22

33
class DevServerTest < Webpacker::Test
4+
def test_running?
5+
with_node_env("production") do
6+
reloaded_config
7+
refute Webpacker.dev_server.running?
8+
end
9+
end
10+
411
def test_host
512
with_node_env("development") do
613
reloaded_config

0 commit comments

Comments
 (0)