Skip to content

Commit 02905ea

Browse files
Phil Elwellpopcornmix
Phil Elwell
authored andcommitted
brcmfmac: Plug memory leak in brcmf_fill_bss_param
See: #1471 Signed-off-by: Phil Elwell <[email protected]>
1 parent d3af8eb commit 02905ea

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2416,7 +2416,7 @@ static void brcmf_fill_bss_param(struct brcmf_if *ifp, struct station_info *si)
24162416
WL_BSS_INFO_MAX);
24172417
if (err) {
24182418
brcmf_err("Failed to get bss info (%d)\n", err);
2419-
return;
2419+
goto out_err;
24202420
}
24212421
si->filled |= BIT(NL80211_STA_INFO_BSS_PARAM);
24222422
si->bss_param.beacon_interval = le16_to_cpu(buf->bss_le.beacon_period);
@@ -2428,6 +2428,9 @@ static void brcmf_fill_bss_param(struct brcmf_if *ifp, struct station_info *si)
24282428
si->bss_param.flags |= BSS_PARAM_FLAGS_SHORT_PREAMBLE;
24292429
if (capability & WLAN_CAPABILITY_SHORT_SLOT_TIME)
24302430
si->bss_param.flags |= BSS_PARAM_FLAGS_SHORT_SLOT_TIME;
2431+
2432+
out_err:
2433+
kfree(buf);
24312434
}
24322435

24332436
static s32

0 commit comments

Comments
 (0)