bcm2708-gpio: Revert the use of pinctrl_request_gpio

In non-DT systems, pinctrl_request_gpio always fails causing
"requests probe deferral" messages. In DT systems, it isn't useful
because the reference counting is independent of the normal pinctrl
pin reservations.

Author: Phil Elwell

arch/arm/mach-bcm2708/bcm2708_gpio.c

@@ -21,6 +21,7 @@
 #include <linux/gpio.h>
 #include <linux/platform_device.h>
 #include <mach/platform.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <linux/platform_data/bcm2708.h>
 
@@ -90,16 +91,6 @@ static int bcm2708_set_function(struct gpio_chip *gc, unsigned offset,
 	return 0;
 }
 
-static int bcm2708_gpio_request(struct gpio_chip *chip, unsigned offset)
-{
-	return pinctrl_request_gpio(chip->base + offset);
-}
-
-static void bcm2708_gpio_free(struct gpio_chip *chip, unsigned offset)
-{
-	pinctrl_free_gpio(chip->base + offset);
-}
-
 static int bcm2708_gpio_dir_in(struct gpio_chip *gc, unsigned offset)
 {
 	return bcm2708_set_function(gc, offset, GPIO_FSEL_INPUT);
@@ -355,8 +346,6 @@ static int bcm2708_gpio_probe(struct platform_device *dev)
 	ucb->gc.ngpio = BCM2708_NR_GPIOS;
 	ucb->gc.owner = THIS_MODULE;
 
-	ucb->gc.request = bcm2708_gpio_request;
-	ucb->gc.free = bcm2708_gpio_free;
 	ucb->gc.direction_input = bcm2708_gpio_dir_in;
 	ucb->gc.direction_output = bcm2708_gpio_dir_out;
 	ucb->gc.get = bcm2708_gpio_get;