Skip to content

Commit 247fb2a

Browse files
Cheong2Kpopcornmix
authored andcommitted
brcm: adds support for BCM43341 wifi
brcmfmac: Disable power management Disable wireless power saving in the brcmfmac WLAN driver. This is a temporary measure until the connectivity loss resulting from power saving is resolved. Signed-off-by: Phil Elwell <[email protected]> brcmfmac: Use original country code as a fallback Commit 73345fd: brcmfmac: Configure country code using device specific settings prevents region codes from working on devices that lack a region code translation table. In the event of an absent table, preserve the old behaviour of using the provided code as-is. Signed-off-by: Phil Elwell <[email protected]> brcmfmac: Plug memory leak in brcmf_fill_bss_param See: #1471 Signed-off-by: Phil Elwell <[email protected]> brcmfmac: do not use internal roaming engine by default Some evidence of curing disconnects with this disabled, so make it a default. Can be overridden with module parameter roamoff=0 See: http://projectable.me/optimize-my-pi-wi-fi/ brcmfmac: Change stop_ap sequence Patch from Broadcom/Cypress to resolve a customer error Signed-off-by: Phil Elwell <[email protected]> Revert "brcmfmac: Disable power management" Shortly after the release of the Pi 3B, a loss of SSH connectivity over WiFi was traced to the power management handling, so power management was disabled. And so it has remained ever since. Enabling power management saves 55mA (~270mW) on a Pi 4B, so is very much worth the minimal effort of reverting this patch, which was squashed and rebased many times since then to the commit hash is meaningless. Signed-off-by: Phil Elwell <[email protected]>
1 parent 83b4074 commit 247fb2a

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3303,7 +3303,7 @@ brcmf_cfg80211_set_power_mgmt(struct wiphy *wiphy, struct net_device *ndev,
33033303
brcmf_dbg(INFO, "Do not enable power save for P2P clients\n");
33043304
pm = PM_OFF;
33053305
}
3306-
brcmf_dbg(INFO, "power save %s\n", (pm ? "enabled" : "disabled"));
3306+
brcmf_err("power save %s\n", (pm ? "enabled" : "disabled"));
33073307

33083308
err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_PM, pm);
33093309
if (err) {

drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ static int brcmf_fcmode;
5959
module_param_named(fcmode, brcmf_fcmode, int, 0);
6060
MODULE_PARM_DESC(fcmode, "Mode of firmware signalled flow control");
6161

62-
static int brcmf_roamoff;
62+
static int brcmf_roamoff = 1;
6363
module_param_named(roamoff, brcmf_roamoff, int, 0400);
6464
MODULE_PARM_DESC(roamoff, "Do not use internal roaming engine");
6565

drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,6 +609,7 @@ BRCMF_FW_DEF(4329, "brcmfmac4329-sdio");
609609
BRCMF_FW_DEF(4330, "brcmfmac4330-sdio");
610610
BRCMF_FW_DEF(4334, "brcmfmac4334-sdio");
611611
BRCMF_FW_DEF(43340, "brcmfmac43340-sdio");
612+
BRCMF_FW_DEF(43341, "brcmfmac43341-sdio");
612613
BRCMF_FW_DEF(4335, "brcmfmac4335-sdio");
613614
BRCMF_FW_DEF(43362, "brcmfmac43362-sdio");
614615
BRCMF_FW_DEF(4339, "brcmfmac4339-sdio");
@@ -641,7 +642,7 @@ static const struct brcmf_firmware_mapping brcmf_sdio_fwnames[] = {
641642
BRCMF_FW_ENTRY(BRCM_CC_4330_CHIP_ID, 0xFFFFFFFF, 4330),
642643
BRCMF_FW_ENTRY(BRCM_CC_4334_CHIP_ID, 0xFFFFFFFF, 4334),
643644
BRCMF_FW_ENTRY(BRCM_CC_43340_CHIP_ID, 0xFFFFFFFF, 43340),
644-
BRCMF_FW_ENTRY(BRCM_CC_43341_CHIP_ID, 0xFFFFFFFF, 43340),
645+
BRCMF_FW_ENTRY(BRCM_CC_43341_CHIP_ID, 0xFFFFFFFF, 43341),
645646
BRCMF_FW_ENTRY(BRCM_CC_4335_CHIP_ID, 0xFFFFFFFF, 4335),
646647
BRCMF_FW_ENTRY(BRCM_CC_43362_CHIP_ID, 0xFFFFFFFE, 43362),
647648
BRCMF_FW_ENTRY(BRCM_CC_4339_CHIP_ID, 0xFFFFFFFF, 4339),

0 commit comments

Comments
 (0)